Actions
Bug #14142
closed
Race condition on all? versions of rack when smart-proxy is configured with both http and https.
Description
An issue in rack around here: https://github.com/rack/rack/blob/master/lib/rack/handler/webrick.rb#L31. A singleton-class variable is being initialized at that spot. It is possible that if more than one call to Rack::Handler::WebRick.run are made sufficiently close to each other, then @server variable is re-initialized with a value from a latter call.
Updated by Dominic Cleal over 8 years ago
I think I'm seeing this issue too, with the symptom being that one of the two servers doesn't get configured correctly. e.g. https_port is 8442, while http_port is 8443 for me, and occasionally I see:
I, [2016-03-17T12:19:14.251516 #20461] INFO -- : WEBrick::HTTPServer#start: pid=20461 port=8442 I, [2016-03-17T12:19:14.251690 #20461] INFO -- : WEBrick::HTTPServer#start: pid=20461 port=8442
The server doesn't respond at all on port 8443 when this happens.
Updated by The Foreman Bot over 8 years ago
- Status changed from New to Ready For Testing
- Assignee set to Anonymous
- Pull request https://github.com/theforeman/smart-proxy/pull/396 added
Updated by The Foreman Bot over 8 years ago
- Pull request https://github.com/theforeman/smart-proxy/pull/397 added
Updated by Dominic Cleal over 8 years ago
- Assignee changed from Anonymous to Dominic Cleal
- Pull request deleted (
https://github.com/theforeman/smart-proxy/pull/396)
Updated by Dominic Cleal over 8 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset e5b669742356ea78974d0e74425704d1c48ad0b9.
Updated by Dominic Cleal over 8 years ago
- Translation missing: en.field_release set to 141
Actions