Project

General

Profile

Actions

Bug #15368

closed

refresh_facts on a renamed discovered host creating second discovered host record

Added by Christopher Chase almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Category:
Discovery plugin
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Description of problem:
Trying to refresh facts on an existing discovered host creates a new discovered host. The new host has the same information but a name based on mac address.

How reproducible:
100%

Steps to Reproduce:
1. Discover a host
2. Update the name on the discovered host to something other than mac address based name
3. refresh_facts
4. Refresh discovered hosts page or data.

I was doing this through the api calls to discovered hosts, but was also able to reproduce on the console:

::Host::Discover.count
dh = ::Host::Discovered.find(<id>)
dh.name = 'copyme'
dh.save
dh.refresh_facts
::Host::Discover.count

Actual results:
A new discovered host with a name based on mac address was found. At this point repeating the process will not create a copy since one already exists.

Expected results:
The facts on the host would be refreshed without creating a new host.

Additional info:
It looked like refresh_facts calling Host::Discovered.import_host would find_by_name and come up empty and create a new host.

Actions #1

Updated by Lukas Zapletal almost 8 years ago

  • Category set to Discovery plugin
  • Target version set to Discovery Plugin 6.0

Thanks for report.

Actions #2

Updated by Lukas Zapletal almost 8 years ago

If you want this to be fixed in Satellite 6.2, create linked BZ and request 6.2.z flag. I will fix this for upstream only for now.

Actions #3

Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman_discovery/pull/275 added
Actions #4

Updated by The Foreman Bot almost 8 years ago

  • Pull request https://github.com/theforeman/foreman_discovery/pull/276 added
Actions #5

Updated by Christopher Chase almost 8 years ago

Created https://bugzilla.redhat.com/show_bug.cgi?id=1347023
Not allowed to edit the Bugzilla Link field, though

Actions #6

Updated by Marek Hulán almost 8 years ago

  • Bugzilla link set to 1347023
Actions #7

Updated by Lukas Zapletal almost 8 years ago

  • Pull request deleted (https://github.com/theforeman/foreman_discovery/pull/275)
Actions #8

Updated by Anonymous almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF