Project

General

Profile

Actions

Bug #15681

closed

Fog Openstack version should require at least version 0.1.7 to ensure compatibility with Openstack Liberty

Added by Imri Zvik over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Compute resources - OpenStack
Target version:
Difficulty:
trivial
Triaged:
Fixed in Releases:
Found in Releases:

Description

Due to changes in Openstack, the Compute API in Liberty (and maybe other APIs) are no longer forgiving for empty values.
See the following commit: https://github.com/fog/fog-openstack/commit/13bfc96ba646c65487c8a619ee84ad5f6268e702

This totally breaks stuff like boot from volume.

Actions #1

Updated by Imri Zvik over 7 years ago

Should probably be

gem 'fog-openstack', '~> 0.1', '>= 0.1.7'

Actions #2

Updated by Dominic Cleal over 7 years ago

The pinning of fog-core to 1.36.0 currently prevents the ~> 0.1 matcher from matching 0.1.7. If fog-core is updated to over 1.40 (either specifically, or unpinned) then we'll automatically inherit a newer version of fog-openstack too.

Actions #3

Updated by Imri Zvik over 7 years ago

Well, since this breaks the functionality quite bad, I think this should get priority.

Note that Liberty is the minimal version of Openstack still supported (http://releases.openstack.org/), so Foreman should probably be compatibable with it.

Actions #4

Updated by Imri Zvik over 7 years ago

Dominic Cleal wrote:

The pinning of fog-core to 1.36.0 currently prevents the ~> 0.1 matcher from matching 0.1.7. If fog-core is updated to over 1.40 (either specifically, or unpinned) then we'll automatically inherit a newer version of fog-openstack too.

btw, another thing to note is that nothing ensures you will get the latest version of 0.1 - see https://github.com/bundler/bundler/issues/3089#issuecomment-48533609 for example.
Therefore, it is probably a good idea to change the requirement anyway.

Actions #5

Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Imri Zvik
  • Pull request https://github.com/theforeman/foreman/pull/3648 added
Actions #6

Updated by Imri Zvik over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #7

Updated by Dominic Cleal over 7 years ago

  • translation missing: en.field_release set to 160
Actions

Also available in: Atom PDF