Bug #15861

audited_changes column is too small

Added by Alejandro Falcon over 1 year ago. Updated 7 months ago.

Status:Closed
Priority:Normal
Assigned To:Amir Fefer
Category:Audit Log
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4556
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

I had an issue this morning when updating a quite long param in foreman:

Data too long for column 'audited_changes' at row 1

A simple fix to this problem was to hack into foreman DB and run "ALTER TABLE audits MODIFY audited_changes MEDIUMTEXT;"

Thanks.

Associated revisions

Revision cf468753
Added by Amir Fefer 8 months ago

Fixes #15861 - increase size of audited_changes column

In mysql text type is limited to 64K, while in psql
there's no limit. Changeing type to MEDIUMTEXT,
which limited to 16MB, should solve this issue in mysql

History

#1 Updated by Dominic Cleal over 1 year ago

  • Category set to Audit Log

The column should be a Rails "text" type, which IIRC is 64k, but the field would probably contain the parameter value and similar info.

#2 Updated by Joe Mader 12 months ago

I've run into this same scenario. We don't use a "sideband" CM platform for tracking host metadata and thus some of our host-specific parameter values stored in the Foreman DB are rather large.

I was not able to conveniently locate an "admin-facing" tunable which could either turn auditing off or otherwise "filter" what gets audited.

Coincidentally, we resorted to changing the "audited_changes" column type to MEDIUMTEXT as a testing workaround. My concern is that this approach is not quite "future proof" (easily superceded by an upstream rails DB migration). Are there notable objections to making MEDIUMTEXT the new default? Given that there appears to be no fulltext index on this column, Foreman system owners would just need to ensure sufficient filesystem storage.

#3 Updated by Amir Fefer 8 months ago

  • Assigned To set to Amir Fefer

#4 Updated by The Foreman Bot 8 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4556 added

#5 Updated by Amir Fefer 8 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Marek Hulán 7 months ago

  • Release set to 1.16.0

Also available in: Atom PDF