Project

General

Profile

Actions

Bug #15861

closed

audited_changes column is too small

Added by Alejandro Falcon over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Audit Log
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

I had an issue this morning when updating a quite long param in foreman:

Data too long for column 'audited_changes' at row 1

A simple fix to this problem was to hack into foreman DB and run "ALTER TABLE audits MODIFY audited_changes MEDIUMTEXT;"

Thanks.

Actions #1

Updated by Dominic Cleal over 7 years ago

  • Category set to Audit Log

The column should be a Rails "text" type, which IIRC is 64k, but the field would probably contain the parameter value and similar info.

Actions #2

Updated by Joe Mader about 7 years ago

I've run into this same scenario. We don't use a "sideband" CM platform for tracking host metadata and thus some of our host-specific parameter values stored in the Foreman DB are rather large.

I was not able to conveniently locate an "admin-facing" tunable which could either turn auditing off or otherwise "filter" what gets audited.

Coincidentally, we resorted to changing the "audited_changes" column type to MEDIUMTEXT as a testing workaround. My concern is that this approach is not quite "future proof" (easily superceded by an upstream rails DB migration). Are there notable objections to making MEDIUMTEXT the new default? Given that there appears to be no fulltext index on this column, Foreman system owners would just need to ensure sufficient filesystem storage.

Actions #3

Updated by Amir Fefer almost 7 years ago

  • Assignee set to Amir Fefer
Actions #4

Updated by The Foreman Bot almost 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4556 added
Actions #5

Updated by Amir Fefer almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #6

Updated by Marek Hulán almost 7 years ago

  • translation missing: en.field_release set to 240
Actions

Also available in: Atom PDF