Refactor #16221: private method `zones_map' called for ActiveSupport::TimeZone:Class - Foreman

Actions

Copy link

Refactor #16221

closed

private method `zones_map' called for ActiveSupport::TimeZone:Class

Added by Dominic Cleal over 8 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Dominic Cleal

Category:

API

Target version:

1.13.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/3759

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

The documentation in the users API controller lists possible values for timezones by calling ActiveSupport::TimeZone.zones_map, however this method is private in Rails 5.0:

MethodError: private method `zones_map' called for ActiveSupport::TimeZone:Class
    /home/dcleal/code/foreman/foreman/app/controllers/api/v2/users_controller.rb:50:in `block (2 levels) in &lt;class:UsersController&gt;'

It should be replaced by a method that remains public.

Note the same list is obtained by the time_zone_select form helper, which lists timezones through .all.