Project

General

Profile

Actions

Refactor #16221

closed

private method `zones_map' called for ActiveSupport::TimeZone:Class

Added by Dominic Cleal over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
API
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The documentation in the users API controller lists possible values for timezones by calling ActiveSupport::TimeZone.zones_map, however this method is private in Rails 5.0:

MethodError: private method `zones_map' called for ActiveSupport::TimeZone:Class
/home/dcleal/code/foreman/foreman/app/controllers/api/v2/users_controller.rb:50:in `block (2 levels) in <class:UsersController>'

It should be replaced by a method that remains public.

Note the same list is obtained by the time_zone_select form helper, which lists timezones through .all.

Actions #1

Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3759 added
Actions #2

Updated by Dominic Cleal over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Dominic Cleal over 7 years ago

  • translation missing: en.field_release set to 160
Actions

Also available in: Atom PDF