Don't call #to_sentence on model associations
|Assigned To:||Dominic Cleal|
|Found in release:||Pull request:||https://github.com/theforeman/foreman/pull/3912|
|Velocity based estimate||-|
Under Rails 5, calling #to_sentence on an association (such as SmartProxy.first.features.to_sentence) no longer works - it's only implemented on Array. It causes:
ActionView::Template::Error: undefined method `to_sentence' for #<Feature::ActiveRecord_Associations_CollectionProxy:0x00000011e105f8>
app/views/about/index.html.erb:35:in `block in app_views_about_index_html_erb_1374804635064850089_72097840'
In a few views .to_sentence is used on an association when it should first call .pluck to retrieve a specific column or call .to_s on the models, before converting to a sentence.