Refactor #16990

Break apart AccessPermissionTest for easier plugin reuse

Added by Justin Sherrill 9 months ago. Updated 9 months ago.

Status:Closed
Priority:Normal
Assigned To:Justin Sherrill
Category:Tests
Target version:-
Difficulty:easy Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/3950
Story points-
Velocity based estimate-
Release1.14.0Release relationshipAuto

Description

Right now if a plugin wants to implement a similar test to the AccessPermissionsTest, it has to redefine all the constants here:

https://github.com/theforeman/foreman/blob/develop/test/unit/foreman/access_permissions_test.rb#L14

if there are any routes added without a namespace (such as adding a new action to the hosts api). If a test tries to require that file, the test is actually executed and if there are additional items that need to be white listed, those will fail.

Associated revisions

Revision 5db36087
Added by Justin Sherrill 9 months ago

Fixes #16990 - make access_perm test reusable

History

#1 Updated by The Foreman Bot 9 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3950 added

#2 Updated by Justin Sherrill 9 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal 9 months ago

  • Tracker changed from Bug to Refactor
  • Release set to 1.14.0

Also available in: Atom PDF