Bug #17300

Attached devices not saved when editing bond network interfaces

Added by Byron Miller 3 months ago. Updated 3 months ago.

Status:Closed
Priority:High
Assigned To:Dominic Cleal
Category:Network
Target version:-
Difficulty: Bugzilla link:
Found in release:1.13.1 Pull request:https://github.com/theforeman/foreman/pull/4013
Story points-
Velocity based estimate-
Release1.13.2Release relationshipAuto

Description

So we upgraded to 1.13.1, found out bonding was broke. I found this PR and applied it to my 1.13.1 instance.
https://github.com/theforeman/foreman/pull/3994

Once i applied that, the form shows bond details, however when i add two interfaces to the bond and click save, the next screen is blank where it should show the interfaces.


Related issues

Related to Foreman - Feature #3917: Add strong_parameters to foreman Closed 12/19/2013

Associated revisions

Revision 18780e5c
Added by Dominic Cleal 3 months ago

fixes #17300 - accept Nic::Bond#attached_devices string inputs

History

#1 Updated by Byron Miller 3 months ago

unfortunately i can't post an awesome video i made to show this issue as it has data that our security team says is confidential/protected so i'm trying to piece together screenshots. I'm provisioning another host right now to manually bond so that i can create a showcase of logging to show how editing a bond causes the data to disappear since i don't want to break any of my working hosts to demo the edit.

#2 Updated by Dominic Cleal 3 months ago

  • Category set to Network
  • Found in release set to 1.13.1

Can you be more specific about what's blank? Is this the attached devices field - it isn't saving changes in this field for an existing bond?

Or are you adding entirely new interfaces to the list and it isn't showing up when the popup window closes?

I think I see an issue with editing attached devices, but I'd like to check that this is the same issue you're experiencing.

#3 Updated by Byron Miller 3 months ago

I'm having multiple problems but this one is specific to an existing host that has a bond. If i click edit on the host and try and change the attached interfaces that are associated to the bond in the interfaces field, my changes disappear and the field is blank when i save it. I don't see the interfaces when i then go and preview the kickstart templates either.

I don't see any errors either when this happens. its like its just ignored. I'm working on a test case to try and re-produce this on a non production system but i'm having another problem that discovered hosts don't show the bond drop down even when the bond drop down is selected (and the patch you contributed is applied) so i'm trying to keep those separate.

#4 Updated by Dominic Cleal 3 months ago

  • Subject changed from Bonds were broke in 1.13.1, applied the fix here: https://github.com/theforeman/foreman/pull/3994 but now the form is blank when i try and save edits on existing hosts. to Attached devices not saved when editing bond network interfaces
  • Status changed from New to Assigned
  • Assigned To set to Dominic Cleal

#5 Updated by Dominic Cleal 3 months ago

Thanks, that confirms it's the same issue I saw here when editing the attached devices field.

The value's being ignored as the parameter filter expects it to be an array (the documented input from the API), but it's a string from the UI. It should permit both.

#6 Updated by The Foreman Bot 3 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4013 added

#7 Updated by Dominic Cleal 3 months ago

  • Related to Feature #3917: Add strong_parameters to foreman added

#8 Updated by Dominic Cleal 3 months ago

  • Release set to 1.13.2

#9 Updated by Dominic Cleal 3 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF