Refactor #17439

Refactor facet base class to a concern.

Added by Shimon Shtein 6 months ago. Updated 6 months ago.

Status:Closed
Priority:Normal
Assigned To:Shimon Shtein
Category:Plugins-Engines
Target version:Team Ivan Iteration 6
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4047
Story points-
Velocity based estimate-
Release1.14.0Release relationshipAuto

Description

We can leave the base class, but we want to leave the inheritance option open.
Example: In Katello there is a base class for all models, so we want to enable ContentFacet class to inherit the base Model and have all facet related methods.


Related issues

Related to Foreman - Refactor #16987: Explicit building of facets Closed 10/18/2016

Associated revisions

Revision 1b38f231
Added by Shimon Shtein 6 months ago

Fixes #17439 - Moved facet base to a concern

If the plugin that wants to create a new facet doesn't want to
take the inheritance slot (for example if it already has some
base class), it can `include` the new concern.

History

#1 Updated by Shimon Shtein 6 months ago

#2 Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4047 added

#3 Updated by Shimon Shtein 6 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal 6 months ago

  • Category set to Plugins-Engines
  • Release set to 1.14.0

Also available in: Atom PDF