Project

General

Profile

Actions

Bug #17457

closed

multiple_checkboxes doesn't work with orgs/locs

Added by Daniel Lobato Garcia over 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Organizations and Locations
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

multiple_checkboxes calls ActiveModel::Naming on associations that could be simply "Taxonomy". This results on a 500 error 'undefined method `taxonomies' for #<Filter:0x005593624bdd18>' (or whatever other class has the problem). Simply trying to edit a filter will throw this 500 error.

https://github.com/theforeman/foreman/blob/develop/app/helpers/form_helper.rb#L49

We've always had this problem , but since #16971 removed the check for only using that method for '> 5' associations, you'd only see the error if you had at least 6 organizations or locations (unlikely). Now it became more apparent and it shows up every time.

Actions #1

Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/4039 added
Actions #2

Updated by Daniel Lobato Garcia over 7 years ago

  • Target version set to 1.4.3
Actions #3

Updated by Daniel Lobato Garcia over 7 years ago

  • Target version changed from 1.4.3 to 1.15.5
Actions #4

Updated by Anonymous over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Dominic Cleal over 7 years ago

  • translation missing: en.field_release set to 189
Actions

Also available in: Atom PDF