Bug #17570

onContentLoad() is called twice on every page

Added by Tomer Brisker 3 months ago. Updated 2 months ago.

Status:Closed
Priority:Normal
Assigned To:Tomer Brisker
Category:Web Interface
Target version:Team Daniel - iteration 6
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4080
Story points-
Velocity based estimate-
Release1.14.1Release relationshipAuto

Description

From the jQuery docs:

when calling .trigger() with an event name matches the name of a property on the object, prefixed by on (e.g. triggering click on window that has a non null onclick method), jQuery will attempt to invoke that property as a method.

When the document loads we trigger a `ContentLoad` event, which causes jQuery to execute the function called `onContentLoad` by default. In addition, we attach a listener to the document that catches the `ContentLoad` event and executes the function as well.
We need to either rename the function or remove the extra listener.

Associated revisions

Revision 83afcbec
Added by Tomer Brisker 2 months ago

Fixes #17570 - Only execute `onContentLoad` once per page

When an event is triggered, jQuery attempts to execute the on<name>
method if it exists for event <name>. We were also manually triggering
the `onContentLoad` every time the `ContentLoad` event was triggered,
leading to the function executing twice on every page.
This commit removes the explicit event listener so that the function
will only execute once.

History

#1 Updated by The Foreman Bot 3 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4080 added

#2 Updated by Daniel Lobato Garcia 2 months ago

  • Target version set to Team Daniel - iteration 6

#3 Updated by Anonymous 2 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal 2 months ago

  • Release set to 1.14.1

Also available in: Atom PDF