Bug #17636

Template preview requires token to be present for template proxying

Added by Lukas Zapletal 6 months ago. Updated 5 months ago.

Status:Closed
Priority:Normal
Assigned To:Lukas Zapletal
Category:Templates
Target version:Team Daniel - iteration 8
Difficulty: Bugzilla link:1404582
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4103
Story points-
Velocity based estimate-
Release1.14.1Release relationshipAuto

Description

Basically I fixed #14479 only in lib/foreman/renderer.rb while we have another copy in app/models/concerns/host_template_helpers.rb. Preview and real template rendering give different results at the moment.

Ideal solution is to refactor this, but we have a separate ticket for that: #8290.


Related issues

Related to Foreman - Bug #14479: Function foreman_url check for tokens Closed 04/05/2016
Related to Foreman - Bug #8290: dry the foreman_url logic that exists in both renderer an... Closed 11/05/2014

Associated revisions

Revision c4ca7740
Added by Lukas Zapletal 6 months ago

Fixes #17636 - token no longer needed for proxied preview

History

#1 Updated by Lukas Zapletal 6 months ago

  • Related to Bug #14479: Function foreman_url check for tokens added

#2 Updated by Lukas Zapletal 6 months ago

  • Description updated (diff)

#3 Updated by Lukas Zapletal 6 months ago

  • Related to Bug #8290: dry the foreman_url logic that exists in both renderer and host_templates_helper added

#4 Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman/pull/4103 added

#5 Updated by Daniel Lobato Garcia 6 months ago

  • Target version set to Team Daniel - iteration 6

#6 Updated by Lukas Zapletal 6 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Dominic Cleal 6 months ago

  • Release set to 1.14.1

#8 Updated by Lukas Zapletal 6 months ago

  • Bugzilla link set to 1404582

#9 Updated by Daniel Lobato Garcia 5 months ago

  • Target version changed from Team Daniel - iteration 6 to Team Daniel - iteration 8

Also available in: Atom PDF