Bug #17870

Saving an empty matcher for smart class parameter of type boolean saves the value false

Added by Ori Rabin 6 months ago. Updated 4 months ago.

Status:Closed
Priority:Normal
Assigned To:Ori Rabin
Category:Smart Variables
Target version:Team Ivan Iteration 7
Difficulty: Bugzilla link:1357049
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4144
Story points-
Velocity based estimate-
Release1.14.1Release relationshipAuto

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1357049

Description of problem:
'Required' functionality is not working for smart class parameter type 'boolean'.

Version-Release number of selected component (if applicable):
Sat 6.2 snap 19.1 GA

How reproducible:
Always

Steps to Reproduce:
1. Set default value for parameter type 'boolean' to true.
2. Select required checkbox to validate that value shouldnt be blank.
3. Create a matcher with empty/blank value.
4. Attempt to submit it.

Actual results:
The parameter is submitted by setting matcher value to 'false' automatically.

Expected results:
1. The parameter should not be submitted and should throw an error 'Value can't be blank'.
2. Autoset of boolean value to false for matcher should not happen.


Related issues

Related to Foreman - Bug #18718: Saving a boolean matcher with no value changes the value ... Closed 02/28/2017

Associated revisions

Revision d836a838
Added by Ori Rabin 6 months ago

Fixes #17870 - Empty boolean matcher should not turn into false

History

#1 Updated by Ori Rabin 6 months ago

  • Status changed from New to Assigned
  • Assigned To set to Ori Rabin
  • Target version set to Team Ivan Iteration 7

#2 Updated by The Foreman Bot 6 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4144 added

#3 Updated by Ori Rabin 6 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal 6 months ago

  • Release set to 1.14.1

#5 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4345 added

#6 Updated by Ori Rabin 4 months ago

  • Related to Bug #18718: Saving a boolean matcher with no value changes the value to false added

#7 Updated by Ori Rabin 4 months ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/4345)

Also available in: Atom PDF