Bug #17998

Only print LDAP bind status if available

Added by Daniel Lobato Garcia 3 months ago. Updated about 1 month ago.

Status:Closed
Priority:Normal
Assigned To:Daniel Lobato Garcia
Category:Logging
Target version:Team Daniel - Iteration 9
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4167
Story points-
Velocity based estimate-
Release1.14.1Release relationshipAuto

Description

The ldap logger tries to call payload[:bind].status but it might not be defined if the bind goes wrong.
This causes a 500 instead of logging the status of the bind. We should display payload[:bind] and only .status if it's available.

Associated revisions

Revision 7447d046
Added by Daniel Lobato Garcia 3 months ago

Fixes #17998 - Only print LDAP bind status if available

The ldap logger tries to call payload[:bind].status but it might not be
defined if the bind goes wrong in some LDAP sources.

This causes a 500 instead of logging the status of the bind. We should
only display payload[:bind].status if it's available.

History

#1 Updated by The Foreman Bot 3 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/4167 added

#2 Updated by Anonymous 3 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal 2 months ago

  • Release set to 1.14.1

#4 Updated by Daniel Lobato Garcia 2 months ago

  • Target version set to Team Brad - Iteration 11

#5 Updated by Brad Buckingham about 1 month ago

  • Target version deleted (Team Brad - Iteration 11)

#6 Updated by Daniel Lobato Garcia about 1 month ago

  • Target version set to Team Daniel - Iteration 9

Also available in: Atom PDF