Project

General

Profile

Actions
Copy link

Bug #18381

closed

PXE loader attribute does not work with host group inheritance

Added by Marek Hulán almost 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Swapnil Abnave
Category:
TFTP
Target version:
1.16.0
Difficulty:
Triaged:
Bugzilla link:
1483948
Pull request:
https://github.com/theforeman/foreman/pull/4260
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

reproducing steps:

1. Define a host group A where you set OS and configure "PXELinux BIOS" (the value does not matter)
2. Define sub host group B, set A as a parent
3. The PXE loader attribute does not inherit anything and prints Inherited parent (no value)

it should show "Inherited value (PXELinux BIOS)" but it does not work. The reason is that other attributes respecting inheritance combines two methods. For example `ptable_id` only return uninherited value while `ptable` works with inheritace. Since pxe_loader is not relation but simple attribute this does not work.

I started to work on the fix but didn't have time to finish it, feel free to inspire at here, the host group form works, but when it's applied in host form, the pxe_loader remains blank.

A workaround I had to do was assigning the pxeloader in all child host groups.

Present probably since 1.13+, see #12634

Related issues 3 (0 open — 3 closed)

Related to Foreman - Feature #12634: New HW Model flag pxe_loader in UI/APIClosedLukas Zapletal11/30/2015Actions
Has duplicate Foreman - Bug #18493: PXE loader is not inherited from parent hostgroupDuplicate02/14/2017Actions
Has duplicate Foreman - Bug #19560: pxe loader not inherited from parent hostgroupDuplicate05/16/2017Actions
Actions
Copy link
 #1

Updated by Marek Hulán almost 8 years ago

  • Related to Feature #12634: New HW Model flag pxe_loader in UI/API added
Actions
Copy link
 #2

Updated by Marek Hulán almost 8 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Swapnil Abnave almost 8 years ago

I started to work on the fix but didn't have time to finish it, feel free to inspire at here, the host group form works, but when it's applied in host form, the pxe_loader remains blank.

I'll try this.

Thanks!

Actions
Copy link
 #4

Updated by Swapnil Abnave almost 8 years ago

  • Assignee set to Swapnil Abnave
  • Target version set to 158
Actions
Copy link
 #5

Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4260 added
Actions
Copy link
 #6

Updated by Dominic Cleal almost 8 years ago

  • Has duplicate Bug #18493: PXE loader is not inherited from parent hostgroup added
Actions
Copy link
 #7

Updated by Swapnil Abnave over 7 years ago

  • Target version changed from 158 to 177
Actions
Copy link
 #8

Updated by Swapnil Abnave over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Dominic Cleal over 7 years ago

  • Has duplicate Bug #19560: pxe loader not inherited from parent hostgroup added
Actions
Copy link
 #10

Updated by Filip Brychta over 7 years ago

I can still see this in foreman 1.15.2

Actions
Copy link
 #11

Updated by Marek Hulán over 7 years ago

  • Translation missing: en.field_release set to 240

The commit https://github.com/theforeman/foreman/commit/b8b00a962d4f1a8ba21877896254845599474946 was merged in develop branch, it means it will be part of new minor release. Setting 1.16.0.

Actions
Copy link
 #12

Updated by Daniel Lobato Garcia over 7 years ago

  • Bugzilla link set to 1483948
Actions
Copy link

Also available in: Atom PDF