Remove quiet_assets dependency, no longer maintained
|Assigned To:||Dominic Cleal|
|Found in release:||Pull request:||https://github.com/theforeman/foreman/pull/4646|
|Velocity based estimate||-|
The quiet_assets gem used in development (when the assets bundler group is installed) is no longer maintained and so doesn't support Rails 5, because it was merged into sprockets-rails 3.1.0.
sprockets-rails 3.1.0 has a quiet flag that implements the same functionality by wrapping the request in the #silence method on the application logger. Note that the #silence method is only a no-op implementation in the logging gem (https://github.com/TwP/logging/issues/11).
fixes #18500 - replace quiet_assets with sprockets-rails flag
- fixes #18512 - support sprockets-rails 3.x
The app.assets environment is no longer always configured, and instead
is only configured when the regular Rails environment is loaded. Loading
only the 'assets' group initializers isn't sufficient.
Because the asset group initializers are no longer run, the plugin API
has been extended with `precompile_assets` and `automatic_assets` to
store and optionally generate a list of assets for that plugin. It
deprecates using an assets initializer, modifying SETTINGS and
`config.assets.precompile` to configure the plugin asset list.
- fixes #18500 - replace quiet_assets with sprockets-rails flag
quiet_assets was merged into sprockets-rails 3.1+ and is no longer
maintained for Rails 5, so it can be removed. Min version hasn't been
increased as it only affects development log verbosity and isn't a hard
dependency. Older versions used in packages will work fine.
The logging gem deliberately doesn't implement the #silence method, so
this is wrapped to fully match the Rails API and make the feature work.