Project

General

Profile

Actions

Refactor #18500

closed

Remove quiet_assets dependency, no longer maintained

Added by Dominic Cleal almost 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Logging
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The quiet_assets gem used in development (when the assets bundler group is installed) is no longer maintained and so doesn't support Rails 5, because it was merged into sprockets-rails 3.1.0.

sprockets-rails 3.1.0 has a quiet flag that implements the same functionality by wrapping the request in the #silence method on the application logger. Note that the #silence method is only a no-op implementation in the logging gem (https://github.com/TwP/logging/issues/11).


Related issues 1 (0 open1 closed)

Blocked by Foreman - Refactor #18512: Support sprockets-rails 3ClosedDominic Cleal02/15/2017Actions
Actions #1

Updated by Dominic Cleal almost 8 years ago

Actions #2

Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4542 added
Actions #3

Updated by The Foreman Bot over 7 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4646 added
Actions #4

Updated by Anonymous over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Marek Hulán over 7 years ago

  • Translation missing: en.field_release set to 240
  • Pull request deleted (https://github.com/theforeman/foreman/pull/4542)
Actions

Also available in: Atom PDF