Bug #18518

New Container wizard is missing proper feedback on image search error

Added by Sebastian Gräßl 7 months ago. Updated 6 months ago.

Status:Closed
Priority:Normal
Assigned To:Sebastian Gräßl
Category:Plugin (foreman_docker)
Target version:Foreman - Team Daniel - Iteration 9
Difficulty: Pull request:https://github.com/theforeman/foreman-docker/pull/186, https://github.com/theforeman/foreman-docker/pull/183
Bugzilla link:1190237

Description

When creating a new container, image search is failing but not giving any user feedback. Also when trying to finish the wizard any feedback is given and the page just not work.

How reproducible:
Aways when an error or failure happens.

Steps to Reproduce:
1. Go to Containers > New Container
2. Select a Compute Resource and go to next step
3. Try to search some image, if an error happens no feedback will be shown
4. In order to test the finish step, just fill the image and tag with any value and proceed to next step
5. Fill the required fields and proceed
6. Try to finish the wizard if it is not able to save the new container no feedback will be given

Actual results:
No error feedback is given

Expected results:
Show some feedback, like an error alert, saying that something went wrong. A message is returned but is only visible when using the Developers Tools console.

Associated revisions

Revision f6a9acbd
Added by Sebastian Gräßl 6 months ago

Fixes #18518 - Add proper validation for container image

For now the image has only been validate via the result
of the search, but not enforced on the server side.

The model validation brings now proper feedback when
the form has been submitted to the server.

Revision 2cbd9000
Added by Sebastian Gräßl 6 months ago

Merge pull request #186 from bastilian/fix/18518-PR2

Fixes #18518 - Add proper validation for container image

History

#1 Updated by The Foreman Bot 7 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-docker/pull/183 added

#2 Updated by Daniel Lobato Garcia 7 months ago

  • Target version set to Team Daniel - Iteration 9

#3 Updated by The Foreman Bot 6 months ago

  • Pull request https://github.com/theforeman/foreman-docker/pull/186 added

#4 Updated by Anonymous 6 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF