Bug #18554: application_helper can be slow when invoking authorized_for as non-admin - Foreman

Actions

Copy link

Bug #18554

closed

application_helper can be slow when invoking authorized_for as non-admin

Added by Chris Duryee about 8 years ago. Updated about 8 years ago.

Status:

Rejected

Priority:

Normal

Assignee:

Chris Duryee

Category:

Users, Roles and Permissions

Target version:

Difficulty:

Triaged:

Bugzilla link:

1422690

Pull request:

https://github.com/theforeman/foreman/pull/4299, https://github.com/theforeman/foreman/pull/4315

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

If you have a non-admin user with rights to view REX jobs, it can be very slow to view the task output. For example:

Rendered /opt/.../app/views/job_invocations/_tab_overview.html.erb (23.2ms)
  Rendered /opt/.../app/views/job_invocations/_host_name_td.html.erb (3065.9ms)
  Rendered /opt/.../app/views/job_invocations/_host_status_td.html.erb (0.5ms)
  Rendered /opt/.../app/views/job_invocations/_host_actions_td.html.erb (3587.1ms)

If you attempt to view the same data as admin, it is fast:

Completed 200 OK in 67ms (Views: 47.9ms | ActiveRecord: 6.9ms)

This problem appears to be very similar to http://projects.theforeman.org/issues/15527.

Actions

Copy link

Updated by The Foreman Bot about 8 years ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/4299 added

Actions

Copy link

Updated by Dominic Cleal about 8 years ago

Translation missing: en.field_release set to 209

The "fix" seems overly broad, disabling the cache on every single call to authorized_for, not just for this one usage in this one plugin. Every UI that checks one permission for multiple resources will generate substantially more database queries.

(As such, unsuitable for 1.14 point release.)

Actions

Copy link