Project

General

Profile

Actions

Bug #18929

closed

rails-observer dependency required for TopbarSweeper

Added by Dominic Cleal about 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Packaging
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

I erroneously removed the explicit rails-observer dep in #14434, but the sweeper functionality used by TopbarSweeper is provided by the rails-observer gem, so the dependency should be restored. (At least while TopbarSweeper exists; I think the remainder of the token refactoring in #14434 remains beneficial.)

Currently rails-observer is installed as a dependency of the audited gem, so it does still work.

Actions #1

Updated by The Foreman Bot about 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4382 added
Actions #2

Updated by Dominic Cleal about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Dominic Cleal about 7 years ago

  • translation missing: en.field_release set to 227
Actions

Also available in: Atom PDF