Project

General

Profile

Actions

Refactor #19002

closed

Use ApplicationRecord instead of ActiveRecord::Base

Added by Lukas Zapletal about 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Branch:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Because Rails 5 will require apps to use ApplicationRecord and because this makes things easier for us to redirect orchestration log messages from sql to orch logger, we are making a change in core and introducing this class (#13772).

Most ActiveRecord::Base use must be replaced, specifically:

app/model/ - model classes
db/migrate/ - "fake" reopened classes otherwise TypeError: superclass mismatch for class XYZ
test/ - reopened classes otherwise TypeError: superclass mismatch for class XYZ

Such an example change can be seen in https://github.com/theforeman/foreman/pull/3729


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #13772: The orchestration code uses SQL loggerClosedLukas Zapletal02/17/2016Actions
Actions #1

Updated by Lukas Zapletal about 7 years ago

  • Related to Bug #13772: The orchestration code uses SQL logger added
Actions #2

Updated by Lukas Zapletal almost 7 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by John Mitsch almost 7 years ago

  • Tracker changed from Support to Refactor
  • translation missing: en.field_release set to 250
  • Pull request https://github.com/Katello/katello/pull/6700 added
Actions

Also available in: Atom PDF