Bug #19017

Use request id instead of session id of tagged logging

Added by Ivan Necas 3 months ago. Updated 3 months ago.

Status:Closed
Priority:Normal
Assigned To:Ivan Necas
Category:Logging
Target version:Team Ivan Iteration 12
Difficulty: Bugzilla link:1408420
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4410
Story points-
Velocity based estimate-
Release1.15.0Release relationshipAuto

Description

#15863 introduced tagged logging. In the review discussion, it was suggested to use session id
if available. Although it seemed as a good idea at the beginning, it has several disadvanteges:

  1. it treats UI and API requests differently
  2. it makes it impossible to differentiate requests made from the session at the same time (notifications
    is one example, but in general, we should not assume the user is performing on request at a time)
  3. the usability of this as correlation id is questionable, especially with asynchronous actions in place

Related issues

Related to Foreman - Feature #15863: Log request IDs (tagged logging) in production.log Closed 07/27/2016

Associated revisions

Revision 4399420e
Added by Ivan Necas 3 months ago

Fixes #19017 - prefer request id over session id in logging

History

#1 Updated by The Foreman Bot 3 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4410 added

#2 Updated by Ivan Necas 3 months ago

  • Related to Feature #15863: Log request IDs (tagged logging) in production.log added

#3 Updated by Ivan Necas 3 months ago

  • Status changed from Ready For Testing to Closed
  • Bugzilla link set to 1408420

#4 Updated by Ivan Necas 3 months ago

  • Subject changed from Use request id instead of session id of lagged logging to Use request id instead of session id of tagged logging
  • Category set to Logging

#5 Updated by Ohad Levy 3 months ago

  • Release set to 1.15.0

#6 Updated by Ivan Necas 3 months ago

  • Target version set to Team Ivan Iteration 12

Also available in: Atom PDF