Project

General

Profile

Actions
Copy link

Refactor #19131

closed

Unpin minitest to permit later 5.x

Added by Dominic Cleal over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dominic Cleal
Category:
Tests
Target version:
1.16.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4432
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

minitest was pinned to 5.1.x during #7230, the upgrade to Ruby on Rails 4.1. The exact reason is unclear (https://github.com/theforeman/foreman/pull/2870#discussion-diff-43727271).

It can be upgraded, but may require some changes to incorrect tests and fixes for deprecation warnings issued for Minitest 6 (e.g. assert_equal nil, [..] should be assert_nil).

Related issues 1 (0 open — 1 closed)

Related to Foreman Remote Execution - Bug #19360: Tests are failling with newest mintestClosedIvan Necas04/24/2017Actions
Actions
Copy link
 #1

Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4432 added
Actions
Copy link
 #2

Updated by Dominic Cleal over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Ivan Necas over 7 years ago

  • Related to Bug #19360: Tests are failling with newest mintest added
Actions
Copy link
 #4

Updated by Marek Hulán about 7 years ago

  • Translation missing: en.field_release set to 240
Actions
Copy link

Also available in: Atom PDF