Refactor #19131: Unpin minitest to permit later 5.x - Foreman

Refactor #19131

Unpin minitest to permit later 5.x

Added by Dominic Cleal about 1 year ago. Updated 6 months ago.

Status:	Closed
Priority:	Normal
Assigned To:	Dominic Cleal
Category:	Tests
Target version:	-
Difficulty:		Bugzilla link:
Found in release:		Pull request:	https://github.com/theforeman/foreman/pull/4432

Story points	-
Velocity based estimate	-
Release	1.16.0	Release relationship	Auto

Description

minitest was pinned to 5.1.x during #7230, the upgrade to Ruby on Rails 4.1. The exact reason is unclear (https://github.com/theforeman/foreman/pull/2870#discussion-diff-43727271).

It can be upgraded, but may require some changes to incorrect tests and fixes for deprecation warnings issued for Minitest 6 (e.g. assert_equal nil, [..] should be assert_nil).

Related issues

Associated revisions

Revision edd5310f
Added by Dominic Cleal about 1 year ago

fixes #19131 - upgrade minitest to latest 5.x

- override minitest's `_` expectation method with the gettext method
- rename `location` let helper, conflicted with a minitest method name
- fix `assert_equal nil, [..]` deprecation warnings, prefer `assert nil`

Contains fixes for tests that leak data or behavioral changes between
tests, as the ordering of test cases is now randomised:

- remove Host/Nic class modifications in orchestration concern test
- move NotificationBlueprint seeding into test transaction, preventing
DB truncation in integration tests from removing the records
- ensure DBCleaner.start is called when in transaction mode to prevent
records leaking out of integration tests
- sort records for reliable comparisons in TaxonomyTest
- move IPs of BMC NIC factory objects to 1.0.0.0/8 to avoid duplicates
- remove duplicate SettingTest cache clear, missing rescue