Refactor #19217

Suggested to update the Close icon to Remove Icon

Added by June Zhang 10 months ago. Updated 3 months ago.

Status:Closed
Priority:Low
Assigned To:June Zhang
Category:Web Interface
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4442, https://github.com/theforeman/foreman/pull/4458, https://github.com/theforeman/foreman/pull/4464
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

In "Add Parameters" and "Add Combinations", we noticed there are "Remove" icons, but currently using the Close icon, based on the icon guideline, we suggest to use the right icon for correct meaning.

[1]Create Host -> Parameters -> Add Parameters
[2]Provisioning Template -> Association -> Add Combinations

Associated revisions

Revision 0cf6d676
Added by June Zhang 9 months ago

Fixes #19217 - update the close icon to remove icon

In "Add Parameters" and "Add Combinations", we noticed
there are "Remove" icons, but currently using the Close
icon, based on the icon guideline, we suggest to use the
right icon for correct meaning.

Revision 29a2ffd9
Added by Dominic Cleal 9 months ago

refs #19217 - extract template combination "Remove" string

History

#1 Updated by The Foreman Bot 10 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4442 added

#2 Updated by The Foreman Bot 10 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4458 added

#3 Updated by June Zhang 9 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal 9 months ago

  • Category set to Web Interface
  • Assigned To set to June Zhang

This seems to have made unrelated changes to capitalisation of headings too (partially reverting #2426).

#5 Updated by The Foreman Bot 9 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4464 added

#6 Updated by Marek Hulán 3 months ago

  • Release set to 1.16.0

Also available in: Atom PDF