Bug #1929

All files created with world-writable permissions

Added by Dominic Cleal about 5 years ago. Updated about 5 years ago.

Status:Closed
Priority:High
Assigned To:Dominic Cleal
Category:Packaging
Target version:1.1
Difficulty: Bugzilla link:
Found in release: Pull request:
Story points-
Velocity based estimate-

Description

The proxy daemon runs with a umask of 0:

(gdb) call umask(0)
$1 = 0

The files and directories it creates all have world-writable bits set, which is dangerous:

-rw-rw-rw-. 1 foreman-proxy foreman-proxy 104 Nov  7 14:51 /var/log/foreman-proxy/access.log
drwxrwxrwx. 2 foreman-proxy foreman-proxy     4096 Oct 28 22:07 /var/lib/tftpboot/boot
-rw-rw-rw-. 1 foreman-proxy foreman-proxy 24337760 May 22 20:55 /var/lib/tftpboot/boot/Fedora-17-x86_64-initrd.img
-rw-rw-rw-. 1 foreman-proxy foreman-proxy  4662160 May  7  2012 /var/lib/tftpboot/boot/Fedora-17-x86_64-vmlinuz
drwxrwxrwx. 2 foreman-proxy foreman-proxy     4096 Oct 28 22:34 /var/lib/tftpboot/pxelinux.cfg
-rw-rw-rw-. 1 foreman-proxy foreman-proxy      161 Oct 28 21:19 /var/lib/tftpboot/pxelinux.cfg/default

Associated revisions

Revision 6093c50d
Added by Dominic Cleal about 5 years ago

fixes #1929 - set umask sensibly to prevent world writable files (CVE-2012-5477)

History

#1 Updated by Ohad Levy about 5 years ago

  • Target version set to 1.1

#2 Updated by Dominic Cleal about 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF