Refactor #19340

new_host vs new_vm variable in compute resource VM partials

Added by Bernhard Suttner 9 months ago. Updated 7 months ago.

Status:Closed
Priority:High
Assigned To:Timo Goebel
Category:Compute resources
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4549
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

new_host was replaced by new_vm because of:
https://github.com/theforeman/foreman/commit/637da2f28accc1378f0326d97adcbb2efc5d9808

There are still 2 places (vmware name, vmware volume disk_mode) in which new_host is used in:
app/views/compute_resources_vms/form/vmware/_volume.html.erb

Associated revisions

Revision c8efc502
Added by Timo Goebel 8 months ago

fixes #19340 - replace all new_host calls with new_vm

History

#1 Updated by Dominic Cleal 9 months ago

  • Tracker changed from Bug to Refactor
  • Subject changed from new_host vs new_vm to new_host vs new_vm variable in compute resource VM partials
  • Category set to Compute resources

#2 Updated by Stefan Heil 8 months ago

  • Related to Bug #19566: Creating a new host VM on xen fails with: undefined method `new_host?' added

#3 Updated by Luke Huxley 8 months ago

  • Priority changed from Normal to High

Bernhard Suttner wrote:

new_host was replaced by new_vm because of:
https://github.com/theforeman/foreman/commit/637da2f28accc1378f0326d97adcbb2efc5d9808

There are still 2 places (vmware name, vmware volume disk_mode) in which new_host is used in:
app/views/compute_resources_vms/form/vmware/_volume.html.erb

This change seems to have broken provision on XenServer compute resources.

#4 Updated by Timo Goebel 8 months ago

  • Related to deleted (Bug #19566: Creating a new host VM on xen fails with: undefined method `new_host?' )

#5 Updated by The Foreman Bot 8 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4549 added

#6 Updated by Timo Goebel 8 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Marek Hulán 7 months ago

  • Release set to 1.16.0

Also available in: Atom PDF