Project

General

Profile

Actions
Copy link

Bug #19354

closed

associated_type is set to a wrong value in audit_extensions.rb

Added by Shimon Shtein over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ori Rabin
Category:
Audit Log
Target version:
1.16.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4165
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

When fixing STI types for :associated field in AuditExtensions#fix_auditable_type, the type is set to the one from :auditable object instead the one from :associated field.
It looks like a copy-paste error.

Actions
Copy link
 #1

Updated by Dominic Cleal over 7 years ago

  • Category set to Audit Log

Specifically, I think this means:

self.associated_type = auditable.type if auditable_type == "Taxonomy" && auditable

Uses the auditable type, but sets associated_type.

Actions
Copy link
 #2

Updated by Shimon Shtein over 7 years ago

exactly, thanks for clarifying!

Actions
Copy link
 #3

Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ori Rabin
  • Pull request https://github.com/theforeman/foreman/pull/4165 added
Actions
Copy link
 #4

Updated by Tomer Brisker over 7 years ago

  • Status changed from Ready For Testing to Closed
  • Translation missing: en.field_release set to 240
Actions
Copy link

Also available in: Atom PDF