Bug #19448

After marking discovered hosts notification as read, new discovered host don't create notification

Added by Tomer Brisker about 1 year ago. Updated 7 months ago.

Status:Ready For Testing
Priority:Normal
Assigned To:Tomer Brisker
Category:Discovery plugin
Target version:Plugin NEXT
Difficulty: Pull request:https://github.com/theforeman/foreman_discovery/pull/377
Bugzilla link:
Story points-
Velocity based estimate-

Related issues

Blocked by Foreman - Bug #21541: Notifications should have an option to mark all as unread Closed 11/01/2017

History

#1 Updated by Ohad Levy 12 months ago

  • Status changed from New to Feedback

for the record, it does update the expiry ts of the notification. I'm in mixed feelings if we should update the read or not?

#2 Updated by Tomer Brisker 12 months ago

IMHO think we should - if you marked discovered hosts as read, then a new host gets discovered, you'd want to get notified about that.

#3 Updated by Marek Hulán 11 months ago

  • Status changed from Feedback to New
  • Target version changed from Plugin 9.1.0 to Plugin NEXT

I'm reopening this, I think people should be notified about newly discovered hosts even if they marked notification about some discovered hosts previously as read. If people are generally not interested in some kind of notification, is there a way to disable it? Something like "do not notify me in future?". Since 9.1.0 was released already, I'm resetting the target version.

#4 Updated by Ohad Levy 8 months ago

if there is a common understanding this should happen for all kind of notifications, you might need to change it in core:
https://github.com/theforeman/foreman/blob/develop/app/models/notification_blueprint.rb#L20

#5 Updated by The Foreman Bot 8 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman_discovery/pull/377 added

#6 Updated by Tomer Brisker 7 months ago

  • Blocked by Bug #21541: Notifications should have an option to mark all as unread added

Also available in: Atom PDF