Bug #19479

two-pane notifications are not visible

Added by Ohad Levy 9 months ago. Updated 7 months ago.

Status:Closed
Priority:Normal
Assigned To:Ohad Levy
Category:Notifications
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4513, https://github.com/theforeman/foreman/pull/4523
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

it seems, that for a long time, two pane generated notifications are hidden from the user.


Related issues

Related to Foreman - Bug #10587: Notification flashes surpressed on subsequent actions Closed 05/22/2015

Associated revisions

Revision b9df73be
Added by Ohad Levy 9 months ago

fixes #19479, #10587, #19500 - two pane notifications are visible

- notification is now inside the content div, allowing two-pane server
responses to include it.
- refactored all notifications to use notification helpers (notice,
warning and error) instead of direct flash manipulation
- also added the usage of flash now via the helpers, and fixed
it in a couple of places it was used incorrectly (mostly clone rendering
which does not redirect at all).
- fixed consisteny to remove trailing dots from toast messages (as it
seems most strings are without dot suffix).
- safer handing if notification div or its data is undefined.

History

#1 Updated by Ohad Levy 9 months ago

  • Related to Bug #10587: Notification flashes surpressed on subsequent actions added

#2 Updated by The Foreman Bot 9 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Ohad Levy
  • Pull request https://github.com/theforeman/foreman/pull/4513 added

#3 Updated by Ohad Levy 9 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal 9 months ago

  • Category set to Notifications

#5 Updated by The Foreman Bot 9 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4523 added

#6 Updated by Marek Hulán 7 months ago

  • Release set to 1.16.0

Also available in: Atom PDF