Feature #19554

Provide warning for unsupported PXE loader combinations

Added by Lukas Zapletal about 1 year ago. Updated 9 months ago.

Status:Closed
Priority:Normal
Assigned To:Tomáš Strachota
Category:Host creation
Target version:Team Marek Iteration 20
Difficulty: Bugzilla link:1489377
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4792, https://github.com/theforeman/foreman/pull/4811
Story points-
Velocity based estimate-
Release1.17.0Release relationshipAuto

Description

Users very often try to provision RHEL 6 with Grub2 in UEFI which leads to boot loading errors (bacically Grub2 prompt or kernel panic).

We need a warning next to PXE Loader flag in the UI if there is known combination of OS and loader that does not work. These currently are:

  • RHEL 6.x and Grub2
  • RHEL 7.x and Grub1
  • Ubuntu 10.x or older and Grub2
  • Ubuntu 11.x or newer and Grub1
  • Debian 2-6 and Grub2
  • Debian 7+ and Grub1

This can be as simple as regular expression and a warning message showing up next to the field in the UI. No actions must be taken. A global setting should be present which will turn this feature of in case user do not want to see these warnings.


Related issues

Related to Foreman - Refactor #20846: refactor usage of ES6 Map to using _set Rejected 09/05/2017

Associated revisions

Revision 805420d1
Added by Tomáš Strachota 9 months ago

Fixes #19554 - Warning for unsupported PXE loader combinations

Revision f9ba69d7
Added by Tomáš Strachota 9 months ago

Fixes #19554 - Warning for unsupported PXE loader combinations

Revision 9f701b61
Added by Tomáš Strachota 9 months ago

Fixes #19554 - Warning for unsupported PXE loader combinations

Revision a940ec7c
Added by Sebastian Gräßl 9 months ago

Refs #19554 - Rewrite to use an Object and not Map

Map is not yet fully supported in all browsers and
would require additional dependencies to be added.

Using a Object with lodash functions achieves the
same and does not require any additional
dependencies.

Revision 62fb64c6
Added by Tomáš Strachota 9 months ago

Fixes #19554 - Warning for unsupported PXE loader combinations

(cherry picked from commit 805420d18ae67be2fa76cc433ef58b685a640afa)

Revision 187ac8c8
Added by Sebastian Gräßl 9 months ago

Refs #19554 - Rewrite to use an Object and not Map

Map is not yet fully supported in all browsers and
would require additional dependencies to be added.

Using a Object with lodash functions achieves the
same and does not require any additional
dependencies.

(cherry picked from commit a940ec7c1cc821212617827633dea46ffd2749c4)

History

#1 Updated by Lukas Zapletal 12 months ago

Good idea would be our status API to do this kind of warnings.

#2 Updated by Marek Hulán 10 months ago

  • Target version set to Team Marek Iteration 18

#3 Updated by Tomáš Strachota 10 months ago

  • Status changed from New to Assigned
  • Assigned To set to Tomáš Strachota

#4 Updated by Lukas Zapletal 10 months ago

Just to clear things little bit, these are known and supported cobinations, we should only issue warning if ANY of these rules are not true:

  • RHEL 6.x and Grub1
  • RHEL 7.x and Grub2
  • Ubuntu 10.x or older and Grub1
  • Ubuntu 11.x or newer and Grub2
  • Debian 2-6 and Grub1
  • Debian 7+ and Grub2

It's actually the opposite of unsupported combinations in the original description. I think we should have a list of supported pairs rather than unsupported, that's all.

#5 Updated by Marek Hulán 10 months ago

  • Target version changed from Team Marek Iteration 18 to Team Marek Iteration 19

#6 Updated by The Foreman Bot 9 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4792 added

#7 Updated by Marek Hulán 9 months ago

  • Target version changed from Team Marek Iteration 19 to Team Marek Iteration 20

#8 Updated by Anonymous 9 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#9 Updated by Daniel Lobato Garcia 9 months ago

  • Release set to 1.15.4

Given the entirety of the check is contained in a class "PXECompatibilityCheck" added in this PR, I'm marking as 1.15.4 as it's very useful.

#10 Updated by The Foreman Bot 9 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4810 added

#11 Updated by The Foreman Bot 9 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4811 added

#12 Updated by Daniel Lobato Garcia 9 months ago

  • Release changed from 1.15.4 to 1.17.0

#13 Updated by Ohad Levy 9 months ago

  • Related to Refactor #20846: refactor usage of ES6 Map to using _set added

#14 Updated by Ohad Levy 9 months ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/4810)

#15 Updated by roman plevka 9 months ago

  • Bugzilla link set to 1489377

Also available in: Atom PDF