Bug #19672

Plugins adding host bulk actions are broken in Foreman 1.15

Added by Marek Hulán 7 months ago. Updated 7 months ago.

Status:Closed
Priority:Normal
Assigned To:Marek Hulán
Category:Web Interface
Target version:-
Difficulty: Bugzilla link:
Found in release:1.15.0 Pull request:https://github.com/theforeman/foreman/pull/4557
Story points-
Velocity based estimate-
Release1.15.1Release relationshipAuto

Description

When #16043 was merged, a new method multiple_with_filter? has been introduced in hosts_controller and exposed via helper_method. It's also being used in generic helper HostsAndHostgroupsHelper#multiple_filter and it works since most actions are implemented in hosts controller. If plugin adds actions (e.g. foreman_openscap - assign compliance policy), a plugin controller is used and the method is undefined. This method should be probably available globally or the helper should duplicate the logic and check for search param presence. I believe this affects all plugins introducing custom bulk actions and should be fixed in 1.15 branch.


Related issues

Related to Foreman - Bug #16043: Unable to select all hosts from the GUI Closed 08/10/2016
Duplicated by OpenSCAP - Bug #19916: Try assign policy of openscap to a host and error appear ... Duplicate 06/04/2017
Duplicated by OpenSCAP - Bug #19518: Assign policy to hosts modal loads indefintely Duplicate 05/11/2017

Associated revisions

Revision 0bbcc6c3
Added by Marek Hulán 7 months ago

Fixes #19672 - fix bulk actions for plugins

Revision c3169aca
Added by Marek Hulán 6 months ago

Fixes #19672 - fix bulk actions for plugins

(cherry picked from commit 0bbcc6c339113e2a4bf93e6a01c56f55a6641f22)

History

#1 Updated by Marek Hulán 7 months ago

  • Related to Bug #16043: Unable to select all hosts from the GUI added

#2 Updated by The Foreman Bot 7 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Marek Hulán
  • Pull request https://github.com/theforeman/foreman/pull/4557 added

#3 Updated by Daniel Lobato Garcia 7 months ago

  • Release set to 1.15.1

#4 Updated by Anonymous 7 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Ondřej Pražák 6 months ago

  • Duplicated by Bug #19916: Try assign policy of openscap to a host and error appear in new katello 3.4 added

#6 Updated by Ondřej Pražák 6 months ago

  • Duplicated by Bug #19518: Assign policy to hosts modal loads indefintely added

Also available in: Atom PDF