Bug #19696: Create/Update user with e-mail address containing extra consecutive dots is allowed - Foreman

Actions

Copy link

Bug #19696

closed

Create/Update user with e-mail address containing extra consecutive dots is allowed

Added by Marek Hulán almost 7 years ago. Updated almost 4 years ago.

Status:

Rejected

Priority:

Low

Assignee:

Rahul Bajaj

Category:

Users, Roles and Permissions

Target version:

Difficulty:

Triaged:

Bugzilla link:

1455501

Pull request:

https://github.com/theforeman/foreman/pull/4587

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1455501

Description of problem:
Create/Update user with e-mail address containing extra consecutive dots is allowed

Version-Release number of selected component (if applicable):

candlepin-2.0.30-1.el7.noarch
candlepin-selinux-2.0.30-1.el7.noarch
foreman-1.15.0-0.1.RC2.el7sat.noarch
foreman-compute-1.15.0-0.1.RC2.el7sat.noarch
foreman-debug-1.15.0-0.1.RC2.el7sat.noarch
foreman-ec2-1.15.0-0.1.RC2.el7sat.noarch
foreman-gce-1.15.0-0.1.RC2.el7sat.noarch
foreman-installer-1.15.0-0.develop.201703100324gitb570b53.el7sat.noarch
foreman-installer-katello-3.5.0-1.nightly.201703312206git730de81.el7sat.noarch
foreman-libvirt-1.15.0-0.1.RC2.el7sat.noarch
foreman-openstack-1.15.0-0.1.RC2.el7sat.noarch
foreman-ovirt-1.15.0-0.1.RC2.el7sat.noarch
foreman-postgresql-1.15.0-0.1.RC2.el7sat.noarch
foreman-proxy-1.15.0-0.1.RC2.el7sat.noarch
foreman-rackspace-1.15.0-0.1.RC2.el7sat.noarch
foreman-selinux-1.15.0-0.1.RC2.el7sat.noarch
foreman-vmware-1.15.0-0.1.RC2.el7sat.noarch
katello-3.4.0-1.rc2.el7sat.noarch
katello-ca-consumer-sat-r220-02.lab.eng.rdu2.redhat.com-1.0-1.noarch
katello-certs-tools-2.4.0-1.el7sat.noarch
katello-client-bootstrap-1.3.0-1.el7sat.noarch
katello-common-3.4.0-1.rc2.el7sat.noarch
katello-debug-3.4.0-1.rc2.el7sat.noarch
katello-default-ca-1.0-1.noarch
katello-installer-base-3.5.0-1.nightly.201703312206git730de81.el7sat.noarch
katello-selinux-3.0.2-1.el7sat.noarch
katello-server-ca-1.0-1.noarch
katello-service-3.4.0-1.rc2.el7sat.noarch
openldap-2.4.40-13.el7.x86_64
pulp-client-1.0-1.noarch
pulp-docker-plugins-2.3.0-1.git.0.02c948c.el7sat.noarch
pulp-katello-1.0.2-1.el7sat.noarch
pulp-puppet-plugins-2.12.1-1.git.0.1aeb10f.el7sat.noarch
pulp-puppet-tools-2.12.1-1.git.0.1aeb10f.el7sat.noarch
pulp-rpm-plugins-2.12.1-1.el7sat.noarch
pulp-selinux-2.12.1-1.git.0.b41b7ba.el7sat.noarch
pulp-server-2.12.1-1.git.0.b41b7ba.el7sat.noarch
python-ldap-2.4.15-2.el7.x86_64
tfm-rubygem-ldap_fluff-0.4.6-1.el7sat.noarch
tfm-rubygem-net-ldap-0.15.0-1.el7sat.noarch

How reproducible:
Always

Steps to Reproduce:
1.hammer user create --firstname="fSqPgRGpBY" --lastname="ALnULfJpKo" --mail="dot..dot@example.com" --login="user" --password="password" --auth-source-id="1"
2.
3.

Actual results:
The user is created
Message,Id
User [user] created,373

Expected results:
[ERROR 2017-05-25 05:47:12 API] 422 Unprocessable Entity
[ERROR 2017-05-25 05:47:12 Exception] Email address is invalid
Could not create the user:
Email address is invalid

Additional info:
The current behavior is reproducible in UI also, and also allow to update the user data with this invalid e-mails
invalid e-mails examples that are invalid and allow the user to be created/updated:
email@example..c
dot..dot@example.com
dot...dot@example....com

Actions

Copy link

Updated by Dominic Cleal almost 7 years ago

Subject changed from Create/Update user with e-mail address containing extra consecutive dots is allowed to Create/Update user with e-mail address containing extra consecutive dots is allowed
Category set to 218
Priority changed from Normal to Low

Repeated characters in the local part ought to be valid. Validation is now carried out by the "mail" gem, not Foreman. (And it probably assumes that because the domain part is implementation dependent, it isn't correct to prevent multiple dots in the domain part either.)

Actions

Copy link