Bug #19730

Warning "not recommended to unlock this template" does not work

Added by Lukas Zapletal 6 months ago. Updated 3 months ago.

Status:Closed
Priority:Normal
Assigned To:Daniel Lobato Garcia
Category:Templates
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4817
Story points-
Velocity based estimate-
Release1.15.4Release relationshipAuto

Description

After upgrade to Foreman 1.15 (dev setup) I don't see vendor set for core templates - it is nil. We need to make sure during migration that all core templates has vendor set to "Foreman" (and "Katello"), so the message is shown.

        if template.vendor
          _("It is not recommended to unlock this template, as it is provided by %{vendor} and may be overwritten. Please consider cloning it instead.") %
            {:vendor => template.vendor}
        end

It is important to show this message for core templates, it's the main reason why we actually implemented template locking. Setting as 1.15 candidate.

Associated revisions

Revision f646ff56
Added by Daniel Lobato Garcia 3 months ago

Fixes #19730 - Add vendor to provisioning templates

Before unlocking a provisioning template, a warning is shown on the
screen. This warning should contain the vendor that provided the
template (normally Foreman or Katello).

Revision 2a616511
Added by Daniel Lobato Garcia 3 months ago

Fixes #19730 - Add vendor to provisioning templates

Before unlocking a provisioning template, a warning is shown on the
screen. This warning should contain the vendor that provided the
template (normally Foreman or Katello).

(cherry picked from commit f646ff568c4a050baf50d726584447da28986669)

Revision 20c2a0c8
Added by Daniel Lobato Garcia 3 months ago

Fixes #19730 - Add vendor to provisioning templates

Before unlocking a provisioning template, a warning is shown on the
screen. This warning should contain the vendor that provided the
template (normally Foreman or Katello).

(cherry picked from commit f646ff568c4a050baf50d726584447da28986669)

History

#1 Updated by Daniel Lobato Garcia 6 months ago

  • Release changed from 1.15.1 to 1.15.2

#2 Updated by Daniel Lobato Garcia 5 months ago

  • Release changed from 1.15.2 to 1.15.3

#3 Updated by Daniel Lobato Garcia 4 months ago

  • Release changed from 1.15.3 to 1.15.4

#4 Updated by The Foreman Bot 3 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/4817 added

#5 Updated by Anonymous 3 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF