Feature #19934

Prioritize attribute order in puppet classes limited to 255 chars

Added by Tomer Brisker 11 months ago. Updated 11 months ago.

Status:Closed
Priority:Normal
Assigned To:Tomer Brisker
Category:Smart Variables
Target version:-
Difficulty: Bugzilla link:1458817
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4572
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1458817

Description of problem:

Prioritize attribute order feature for puppet class override does not allow more than 255 characters.

Version-Release number of selected component (if applicable): 6.2.9

How reproducible: Always

Steps to Reproduce:
1. Go to Sat Webui, "Configure" --> "Classes" --> Select a class
2. Go to "Smart Class Parameter" --> Select a class and click on override
3. Enter/paste more than 255 chars in the "Order" field and try to save it

Actual results:

Errors out with "is too long (maximum is 255 characters)"

Expected results:

Should get accepted

Additional info:

Customer is trying for 604 chars

Associated revisions

Revision 7943ff79
Added by Tomer Brisker 11 months ago

Fixes #19934 - Don't limit smart class parameter order length

History

#1 Updated by Daniel Lobato Garcia 11 months ago

  • Tracker changed from Bug to Feature
  • Priority changed from High to Normal

This is really an RFE, the field 'Order' is only meant to contain the types of matchers, not the values of the matchers themselves.

fqdn
hostgroup
os
domain

Instead I believe you want to input hostgroup labels directly and have Foreman automatically understand you want to match hostgroups params in a certain order.

We can trivially remove the limit but it won't help with the goal you have, as the field isn't meant for that, hence why I'm changing it to RFE (it makes sense though)

#2 Updated by The Foreman Bot 11 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/4572 added

#3 Updated by Anonymous 11 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Marek Hulán 11 months ago

  • Release set to 1.16.0

Also available in: Atom PDF