Bug #19947

Can't create bookmark for global parameters

Added by Tomer Brisker 5 months ago. Updated 3 months ago.

Status:Closed
Priority:Normal
Assigned To:Ondřej Pražák
Category:Search
Target version:-
Difficulty: Bugzilla link:1456833
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4661
Story points-
Velocity based estimate-
Release1.15.3Release relationshipAuto

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1456833

Description of problem:
It is not possible to create bookmark for Global Parameters, neither via API nor UI.

API:

Making HTTP POST request to https://sat6.com/api/v2/bookmarks with options {'verify': False, 'auth': ('admin', 'changeme'), 'headers': {'content-type': 'application/json'}} and data {"controller": "common_parameters", "query": "\u5653\u3def\uf902\ud855\udcbf\ud849\udf20\u1d9b\ud835\udc10\ud86a\udecd\ud3da\ufa11", "public": false, "name": "uZSPlCrazx"}.
Received HTTP 422 response: {

"error": {"id":null,"errors":{"controller":["common_parameters is not a valid controller"]},"full_messages":["Controller common_parameters is not a valid controller"]}

UI:
After clicking on `create bookmark` modal window is opened, but after clicking on submit button page redirects to `create bookmark` page and further clicking on sumbit button ha no effect.

According to production.log in this case also `common_parameters` is used as controller:

2017-05-30 08:17:02 83131396 [app] [I] Started GET "/bookmarks/new?kontroller=common_parameters&query=name%20=%20123" for 10.40.204.237 at 2017-05-30 08:17:02 -0400
2017-05-30 08:17:02 83131396 [app] [I] Processing by BookmarksController#new as HTML
2017-05-30 08:17:02 83131396 [app] [I] Parameters: {"kontroller"=>"common_parameters", "query"=>"name = 123"}
2017-05-30 08:17:02 83131396 [app] [I] Current user: admin (administrator)
2017-05-30 08:17:02 83131396 [app] [I] Rendered bookmarks/_form.html.erb (3.0ms)
2017-05-30 08:17:02 83131396 [app] [I] Rendered bookmarks/new.html.erb within layouts/application (3.5ms)
2017-05-30 08:17:02 83131396 [app] [I] Rendered layouts/_application_content.html.erb (0.2ms)
2017-05-30 08:17:02 83131396 [app] [I] Rendered home/_submenu.html.erb (1.8ms)
2017-05-30 08:17:02 83131396 [app] [I] Rendered home/_user_dropdown.html.erb (1.4ms)
2017-05-30 08:17:02 83131396 [app] [I] Read fragment views/tabs_and_title_records-3 (0.2ms)
2017-05-30 08:17:02 83131396 [app] [I] Rendered home/_topbar.html.erb (4.6ms)
2017-05-30 08:17:02 83131396 [app] [I] Rendered layouts/base.html.erb (6.2ms)
2017-05-30 08:17:02 83131396 [app] [I] Completed 200 OK in 19ms (Views: 10.9ms | ActiveRecord: 1.2ms)
2017-05-30 08:17:06 4caa26af [app] [I] Started POST "/bookmarks" for 10.40.204.237 at 2017-05-30 08:17:06 -0400
2017-05-30 08:17:06 4caa26af [app] [I] Processing by BookmarksController#create as HTML
2017-05-30 08:17:06 4caa26af [app] [I] Parameters: {"utf8"=>"✓", "authenticity_token"=>"FDUvxMSUQS892j3fW+NYPlNGRzozZybI/DR0SLLhZdKzqQ6GpO/0+UGE1sMTxmAUyG8fD9I3cyY6NLaZ4nBufw==", "bookmark"=>{"name"=>"name", "query"=>"name = 123", "public"=>"1", "controller"=>"common_parameters"}, "commit"=>"Submit"}

Version-Release number of selected component (if applicable):
Sat 6.3/downstream nightly:
  • satellite-6.3.0-12.1.beta.el7sat.noarch
  • foreman-1.15.0-0.1.RC2.el7sat.noarch

How reproducible:
Always

Steps to Reproduce:
1. Navigate to Configure / Global Parameters
2. Use search
3. Try to bookmark this search

Actual results:
Bookmark can't be created

Expected results:
Bookmark should be created

Additional info:

Associated revisions

Revision 8115d074
Added by Ondřej Pražák 3 months ago

Fixes #19947 - Fix creating bookmarks for global params

Revision 308f59f8
Added by Ondřej Pražák 2 months ago

Fixes #19947 - Fix creating bookmarks for global params

(cherry picked from commit 8115d074abbca1feeed5f58fd8cf6f1aa68e4f02)

History

#1 Updated by The Foreman Bot 3 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Ondřej Pražák
  • Pull request https://github.com/theforeman/foreman/pull/4661 added

#2 Updated by Daniel Lobato Garcia 3 months ago

  • Release set to 1.15.3

#3 Updated by Anonymous 3 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF