Refactor #20033

Avoid redefining SEEDED_TEMPLATES and SEEDED_PARTITION_TABLES constants

Added by Marek Hulán 7 months ago. Updated 7 months ago.

Status:Closed
Priority:Normal
Assigned To:Marek Hulán
Category:DB migrations
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4596, https://github.com/theforeman/foreman/pull/4630
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

Since db migration loads these constants from seeds.d and seed task does not use require but rather load, both constants can be redefined resulting in Ruby printing warning. The issue was introduced by #18639


Related issues

Related to Foreman - Bug #18639: All templates that are shipped with Foreman should be loc... Closed 02/23/2017

Associated revisions

Revision bbb1b90c
Added by Marek Hulán 7 months ago

Fixes #20033 - load seed data just once

Revision 597501b4
Added by Lukas Zapletal 7 months ago

Fixes #20143 - changed kind for Preseed default PXEGrub2 (#4630)

  • Fixes #20143 - changed kind for Preseed default PXEGrub2
  • Refs #20033 - renamed contents of templates seeds

Revision dc77e8f6
Added by Lukas Zapletal 7 months ago

Fixes #20143 - changed kind for Preseed default PXEGrub2 (#4630)

  • Fixes #20143 - changed kind for Preseed default PXEGrub2
  • Refs #20033 - renamed contents of templates seeds

(cherry picked from commit 597501b460f4d1131870f6d3e7f4fbae5d6db830)

History

#1 Updated by Marek Hulán 7 months ago

  • Related to Bug #18639: All templates that are shipped with Foreman should be locked by default added

#2 Updated by The Foreman Bot 7 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4596 added

#3 Updated by Anonymous 7 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Marek Hulán 7 months ago

  • Release set to 1.16.0

#5 Updated by The Foreman Bot 7 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4630 added

Also available in: Atom PDF