Bug #20173

Concurrent calls to Subnet#unused_ip may return the same ip address

Added by Dmitri Dolguikh 5 months ago. Updated 4 months ago.

Status:Closed
Priority:Normal
Assigned To:Dmitri Dolguikh
Category:DHCP
Target version:-
Difficulty: Bugzilla link:1459644
Found in release: Pull request:https://github.com/theforeman/smart-proxy/pull/534
Story points-
Velocity based estimate-
Release1.15.4Release relationshipAuto

Description

In the time between lock file existence check and lock file creation it is possible for other threads to successfully pass File.exists? check, therefore creating a race condition.


Related issues

Related to Smart Proxy - Bug #20474: Multiple free IPs returned after record deletion Closed 08/01/2017

Associated revisions

Revision 37e40729
Added by Dmitri Dolguikh 5 months ago

Fixes #20173,#6819 - removed race condition in Subnet#unused_ip

History

#1 Updated by Dmitri Dolguikh 5 months ago

  • Bugzilla link set to 1459644

#2 Updated by Dmitri Dolguikh 5 months ago

  • Category set to DHCP

#3 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Dmitri Dolguikh
  • Pull request https://github.com/theforeman/smart-proxy/pull/534 added

#4 Updated by Anonymous 5 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Lukas Zapletal 4 months ago

  • Related to Bug #20474: Multiple free IPs returned after record deletion added

#6 Updated by Lukas Zapletal 4 months ago

  • Release set to 1.15.4

BZ associated, we need a cherry pick thanks.

Also available in: Atom PDF