Bug #20287

plugin asset precompilation broken with sprockets-rails 3.x

Added by Michael Moll 10 months ago. Updated 9 months ago.

Status:Closed
Priority:High
Assigned To:Michael Moll
Category:Plugins-Engines
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4673
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

23:54:48 ** Execute plugin:assets:precompile
23:54:48 rake aborted!
23:54:48 NoMethodError: undefined method `register_engine' for nil:NilClass
23:54:48 /usr/share/foreman/lib/tasks/plugin_assets.rake:52:in `initialize'
23:54:48 /usr/share/foreman/lib/tasks/plugin_assets.rake:107:in `new'
23:54:48 /usr/share/foreman/lib/tasks/plugin_assets.rake:107:in `block in <top (required)>'
23:54:48 /usr/share/foreman/vendor/ruby/2.1.0/gems/rake-12.0.0/lib/rake/task.rb:250:in `call'

Related: https://github.com/rails/sprockets-rails/issues/237

This is breaking all new packaging of plugins for DEB.


Related issues

Related to Foreman - Refactor #18512: Support sprockets-rails 3 Closed 02/15/2017

Associated revisions

Revision 56c18f27
Added by Michael Moll 10 months ago

Refs #20287 - pin down sprockets-rails to 2.x

Revision b8139123
Added by Michael Moll 9 months ago

Fixes #20287 - fix plugin assets precompilation

The error was only visible with RAILS_ENV=production

Revision d86dc32a
Added by Michael Moll 9 months ago

Refs #20287 - unpin sprockets-rails again

This reverts commit 56c18f27e43876a31007875e8ab6403aea862723.

History

#1 Updated by Michael Moll 10 months ago

#2 Updated by The Foreman Bot 10 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Michael Moll
  • Pull request https://github.com/theforeman/foreman/pull/4673 added

#3 Updated by Michael Moll 9 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF