Bug #20396

Plugin automatic assets detection doesn't respect plugin configuration

Added by Ohad Levy 6 months ago. Updated 6 months ago.

Status:Closed
Priority:Normal
Assigned To:Ivan Necas
Category:Plugins-Engines
Target version:Team Ivan Iteration 18
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4698
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

The assets registered via plugin settings should not be reported as warning.

From the logs on develop:

[app] [W] Plugin foreman-tasks has assets outside of its namespace, these will be ignored: trigger_form.js, foreman_tasks/trigger_form.css, foreman_tasks/tasks.css.scss, 
foreman_tasks/application.css.scss

The assets are registered in the plugin settings.


Related issues

Related to Foreman - Refactor #18512: Support sprockets-rails 3 Closed 02/15/2017

Associated revisions

Revision b17de844
Added by Ivan Necas 6 months ago

Fixes #20396 - better handling of detection of plugin assets

1. don't warn on assets that were added by plugin configuration
2. handle '-' in plugin name

History

#1 Updated by Ivan Necas 6 months ago

  • Project changed from Foreman Remote Execution to Foreman
  • Subject changed from assets outside of its namespace to Plugin automatic assets detection doesn't respect plugin configuration
  • Description updated (diff)
  • Status changed from New to Assigned
  • Assigned To set to Ivan Necas
  • Target version set to Team Ivan Iteration 18

Moving to foreman, as this is an issue on plugin registration API.

#2 Updated by The Foreman Bot 6 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4698 added

#3 Updated by Ivan Necas 6 months ago

  • Category set to Plugins-Engines

#4 Updated by Daniel Lobato Garcia 6 months ago

  • Release set to 1.16.0

#5 Updated by Ohad Levy 6 months ago

#6 Updated by Ivan Necas 6 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF