Bug #20646

Cloning Host: Device Identifier has already been taken

Added by Timo Goebel 3 months ago. Updated 3 months ago.

Status:Closed
Priority:Normal
Assigned To:Timo Goebel
Category:Host creation
Target version:-
Difficulty: Bugzilla link:
Found in release:1.15.0 Pull request:https://github.com/theforeman/foreman/pull/4754
Story points-
Velocity based estimate-
Release1.15.4Release relationshipAuto

Description

When cloning a host with a nic with a interface identifier set, the interface identifier is correctly copied from the original host. Even if the original and cloned hosts just have a single interface each, the cloned host's device identifier field is marked as invalid because the value "has already been taken".

When the interface is cloned, the host_id is copied from the original host. The uniqueness validation is scoped to host_id.

Associated revisions

Revision adbb8b53
Added by Timo Goebel 3 months ago

fixes #20646 - clear host_id during interface cloning

Revision c23ae988
Added by Timo Goebel 2 months ago

fixes #20646 - clear host_id during interface cloning

(cherry picked from commit adbb8b53355314e1ee3bf0002ec6b224a911b31e)

History

#1 Updated by The Foreman Bot 3 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4754 added

#2 Updated by Marek Hulán 3 months ago

What a bug :-) I saw the PR, from quick look I think it's ready to merge. I'll try to test it next week, if someone won't get to it earlier.

#3 Updated by Ohad Levy 3 months ago

  • Release set to 1.15.4

I'm proposing this to 15.4, feel free to ack/nack as needed.

#4 Updated by Timo Goebel 3 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF