Bug #20710

View diff modal window overflows

Added by Marek Hulán 5 months ago. Updated 5 months ago.

Status:Closed
Priority:Normal
Assigned To:Marek Hulán
Category:Reporting
Target version:Team Marek Iteration 20
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4779
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

While verifying #2816 I realized we have the overflow issue again. For some reason we hardcode the value in JS which seems to be prone to regression. I'll open the PR with the same fix we took last time but I'll be happy to hear from front-end experts how to solve it better.


Related issues

Related to Foreman - Bug #2816: diff view broken Resolved 07/22/2013

Associated revisions

Revision 3664d8fd
Added by Marek Hulán 5 months ago

Fixes #20710 - fix view diff width

Revision a3c1dc2f
Added by Marek Hulán 4 months ago

Fixes #20710 - fix view diff width

(cherry picked from commit 3664d8fd29cc5ebdaad302e171bd7f26c3f68046)

History

#1 Updated by Marek Hulán 5 months ago

  • Related to Bug #2816: diff view broken added

#2 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4779 added

#3 Updated by Marek Hulán 5 months ago

  • Target version changed from Team Marek Iteration 19 to Team Marek Iteration 20

#4 Updated by Tomer Brisker 5 months ago

  • Release set to 1.16.0

#5 Updated by Marek Hulán 5 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF