Project

General

Profile

Actions

Refactor #21360

closed

Remove legacy code for Ruby <= 2.0 from hammer-cli-foreman

Added by Tomáš Strachota over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Hammer core
Target version:
-
Difficulty:
easy
Triaged:
No
Team Backlog:
Fixed in Releases:
Found in Releases:
In Kanboard:

Description

Hammer plugin for the Foreman no longer supports ruby 2.0, there's no point of keeping the historical code.

From my search there's following places containing some compatibility code that should be removed:

./hammer/hammer-cli-foreman/lib/hammer_cli_foreman/option_builders.rb:
   93  
   94      def unique(resources)
   95:       # ruby 1.8 hack - it does not support passing blocks to Array#uniq
   96        resources.inject({}) do |h, r|
   97          h.update(r.name => r)

./hammer/hammer-cli-foreman/Gemfile:
    4  
    5  gem 'gettext', '>= 3.1.3', '< 4.0.0'
    6: if RUBY_VERSION < '2.1.0'
    7    gem 'fast_gettext', '< 1.2.0'
    8  end


Related issues 1 (0 open1 closed)

Related to Hammer CLI - Refactor #21359: Remove legacy code for Ruby < 2.0 from hammer-cliClosedOleh FedorenkoActions
Actions #1

Updated by Tomáš Strachota over 6 years ago

  • Related to Refactor #21359: Remove legacy code for Ruby < 2.0 from hammer-cli added
Actions #2

Updated by Oleh Fedorenko almost 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Oleh Fedorenko
  • Triaged set to No
Actions #3

Updated by The Foreman Bot almost 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/372 added
Actions #4

Updated by Tomáš Strachota over 5 years ago

  • Subject changed from Remove legacy code for Ruby < 2.0 from hammer-cli-foreman to Remove legacy code for Ruby <= 2.0 from hammer-cli-foreman

Updating the title. The comparison sign didn't correspond with the issue description.

Actions #5

Updated by Oleh Fedorenko over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #6

Updated by Tomer Brisker over 5 years ago

  • Fixed in Releases hammer-cli-foreman-0.14.0 added
Actions

Also available in: Atom PDF