Project

General

Profile

Actions

Bug #21797

closed

do not log stack trace if generateapplicability generates a 404

Added by Chris Duryee over 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Hosts
Target version:
Fixed in Releases:
Found in Releases:

Description

If a host is unregistered while there is a GenerateApplicability task in the queue, a big stack trace is logged (top few lines shown):

2017-11-28 12:27:15  [foreman-tasks/action] [E] 404 Not Found (RestClient::NotFound)
 | /opt/theforeman/tfm/root/usr/share/gems/gems/rest-client-2.0.1/lib/restclient/abstract_response.rb:223:in `exception_with_response'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/rest-client-2.0.1/lib/restclient/abstract_response.rb:103:in `return!'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/runcible-2.2.0/lib/runcible/base.rb:81:in `block in get_response'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/rest-client-2.0.1/lib/restclient/request.rb:807:in `call'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/rest-client-2.0.1/lib/restclient/request.rb:807:in `process_result'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/rest-client-2.0.1/lib/restclient/request.rb:725:in `block in transmit'
 | /opt/rh/rh-ruby22/root/usr/share/ruby/net/http.rb:853:in `start'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/rest-client-2.0.1/lib/restclient/request.rb:715:in `transmit'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/rest-client-2.0.1/lib/restclient/request.rb:145:in `execute'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/rest-client-2.0.1/lib/restclient/request.rb:52:in `execute'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/rest-client-2.0.1/lib/restclient/resource.rb:67:in `post'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/runcible-2.2.0/lib/runcible/base.rb:80:in `get_response'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/runcible-2.2.0/lib/runcible/base.rb:68:in `call'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/runcible-2.2.0/lib/runcible/resources/consumer.rb:156:in `regenerate_applicability_by_id'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.6.0/app/lib/actions/pulp/consumer/generate_applicability.rb:11:in `invoke_external_task'

Katello does the correct behavior by marking this task as stopped/warning, but the log message can be concerning to users. Instead, we should just log that the host no longer exists in Pulp.


Related issues 1 (1 open0 closed)

Related to Katello - Bug #24077: Uncaught exception when pulp task isnt created from dynflow stepNewActions
Actions #1

Updated by Chris Duryee over 6 years ago

  • Description updated (diff)
Actions #2

Updated by Chris Duryee over 6 years ago

  • Description updated (diff)
Actions #3

Updated by Chris Duryee about 6 years ago

  • Project changed from Runcible to Katello
Actions #4

Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7206 added
Actions #5

Updated by Justin Sherrill about 6 years ago

  • Category set to Hosts
  • translation missing: en.field_release set to 338
Actions #6

Updated by Chris Duryee about 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #7

Updated by Zach Huntington-Meath about 6 years ago

  • translation missing: en.field_release changed from 338 to 284
Actions #8

Updated by The Foreman Bot about 6 years ago

  • Pull request https://github.com/Katello/katello/pull/7214 added
Actions #9

Updated by Adam Ruzicka almost 6 years ago

  • Related to Bug #24077: Uncaught exception when pulp task isnt created from dynflow step added
Actions

Also available in: Atom PDF