Project

General

Profile

Actions
Copy link

Feature #22253

closed

Extend option validators to validate resolved options

Added by Martin Bacovsky about 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomáš Strachota
Category:
Hammer core
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/hammer-cli/pull/242, https://github.com/theforeman/hammer-cli-foreman/pull/402
Team Backlog:
Fixed in Releases:
Found in Releases:
In Kanboard:
Red Hat JIRA:

Description

Implementation idea would be:
- validation object instead of block
- possibility to use it during option collecting in selected order
- get partially collected options as an input

Actions
Copy link
 #1

Updated by Martin Bacovsky about 7 years ago

  • Category set to Hammer core
Actions
Copy link
 #3

Updated by Tomáš Strachota about 7 years ago

I'll add a few comments:
  • Validation objects should be kept in the same array as option sources to enable mixing them and validating some options before a certain option source is executed.
  • The current 'validate_options' block should be silently translated to a validation object to keep backward compatibility while being consistent in how we do validations.
Actions
Copy link
 #4

Updated by Tomáš Strachota about 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Tomáš Strachota
Actions
Copy link
 #5

Updated by The Foreman Bot about 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli/pull/242 added
Actions
Copy link
 #6

Updated by The Foreman Bot about 6 years ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/402 added
Actions
Copy link
 #7

Updated by Anonymous about 6 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF