Project

General

Profile

Actions
Copy link

Bug #2685

closed

Regular expression problems on checking installation media name

Added by Ivan Necas over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ivan Necas
Category:
-
Target version:
1.2.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

When creating a media with some format can lead to the foreman being stuck:

The root cause is the regular expression checking the name of media on spaces:

"SimpleOrg/Dev_Env/PublishedRHEL532 RHEL Server 5.9 i386" =~ /\A(\S+\s?)+\Z

This takes ages to compute.

On the other hand, it doesn't catch this example "My Media with trailing space "

The more efficient and working regexp should be

/\A(\S+\s)*\S+\Z/

Going to send a PR

(from https://bugzilla.redhat.com/show_bug.cgi?id=976362)

Actions
Copy link
 #1

Updated by Dominic Cleal over 11 years ago

  • Status changed from Assigned to Ready For Testing
  • Target version set to 1.2.0
Actions
Copy link
 #2

Updated by Ivan Necas over 11 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF