Project

General

Profile

Actions
Copy link

Refactor #3016

closed

accessible_hostgroups method unnecessarily sorts in memory

Added by Ohad Levy about 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomer Brisker
Category:
Performance
Target version:
1.9.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2215
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

since we added the full label to the db, we can ask the db to sort for us.

see source:app/helpers/hosts_and_hostgroups_helper.rb#L20

Actions
Copy link
 #1

Updated by Ohad Levy about 11 years ago

also, changing the order to check first for an admin should improve the query a bit (when you are an admin).

Actions
Copy link
 #2

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2215 added
Actions
Copy link
 #3

Updated by Tomer Brisker over 9 years ago

  • Assignee set to Tomer Brisker
Actions
Copy link
 #4

Updated by Anonymous over 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Marek Hulán over 9 years ago

  • Category set to Performance
  • Translation missing: en.field_release set to 35
Actions
Copy link

Also available in: Atom PDF