Bug #3512

--help output for some commands uses generic "resource" word instead of resource name

Added by Dominic Cleal over 4 years ago. Updated over 3 years ago.

Status:Closed
Priority:Low
Assigned To:Martin Bacovsky
Category:Foreman commands
Target version:Foreman - Sprint 24
Difficulty: Bugzilla link:1023164
Found in release: Pull request:
Story points-
Velocity based estimate-

Description

Lots of the help results for 'location' should have text that is a little more applicable to the specified subcommand.

Steps to Reproduce:
1. hammer -u admin -p admin location --help

Actual results:

Usage:
    hammer location [OPTIONS] SUBCOMMAND [ARG] ...

Parameters:
    SUBCOMMAND                    subcommand
    [ARG] ...                     subcommand arguments

Subcommands:
    remove_medium                 Disassociate a resource
    remove_configtemplate         Disassociate a resource
    remove_environment            Disassociate a resource
    remove_smartproxy             Disassociate a resource
    add_computeresource           Associate a resource
    list                          List all locations
    add_medium                    Associate a resource
    add_configtemplate            Associate a resource
    update                        Update a location
    add_environment               Associate a resource
    remove_subnet                 Disassociate a resource
    remove_organization           Disassociate a resource
    remove_domain                 Disassociate a resource
    remove_user                   Disassociate a resource
    delete                        Delete a location
    remove_hostgroup              Disassociate a resource
    add_smartproxy                Associate a resource
    add_subnet                    Associate a resource
    add_organization              Associate a resource
    add_domain                    Associate a resource
    add_user                      Associate a resource
    create                        Create a location
    add_hostgroup                 Associate a resource
    remove_computeresource        Disassociate a resource
    info                          Show a location

Expected results:

Usage:
    hammer location [OPTIONS] SUBCOMMAND [ARG] ...

Parameters:
    SUBCOMMAND                    subcommand
    [ARG] ...                     subcommand arguments

Subcommands:
    remove_medium                 Disassociate a medium
    remove_configtemplate         Disassociate a configuration template
    remove_environment            Disassociate an environment
    remove_smartproxy             Disassociate a smart proxy
    add_computeresource           Associate a compute resource
    list                          List all locations
    [...]

...and so on. Likewise for the "Associate a resource" lines.

(https://bugzilla.redhat.com/show_bug.cgi?id=1023164)

Associated revisions

Revision 5b425fca
Added by Martin Bačovský over 3 years ago

Fixes #3512 - help for associating commands is too generic

Revision ff975648
Added by Tomas Strachota over 3 years ago

Merge pull request #124 from mbacovsky/3512_associated_descrs

Fixes #3512 - help for associating commands is too generic

History

#1 Updated by Dominic Cleal over 4 years ago

  • Description updated (diff)

#2 Updated by Dominic Cleal over 3 years ago

  • Bugzilla link set to https://bugzilla.redhat.com/show_bug.cgi?id=1023164

#3 Updated by Martin Bacovsky over 3 years ago

  • Status changed from New to Ready For Testing

#4 Updated by Dominic Cleal over 3 years ago

  • Assigned To set to Martin Bacovsky
  • Target version set to Sprint 24

#5 Updated by Tomáš Strachota over 3 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF