Bug #3569

Port in use by the browser is used in rendering the templates

Added by Greg Sutcliffe over 4 years ago. Updated over 4 years ago.

Status:Closed
Priority:Normal
Assigned To:Greg Sutcliffe
Category:Unattended installations
Target version:Sprint 16
Difficulty: Bugzilla link:
Found in release: Pull request:
Story points-
Velocity based estimate-
Release1.4.0Release relationshipAuto

Description

We fixed the hostname version of this issue a while back, but the port got missed. If you use a non-standard port to access foreman, it'll be written into your templates, which makes tunnelling in from home a real pain.

We should update :foreman_url to be a real url and then parse it for the host and port


Related issues

Related to Foreman - Bug #3210: We set foreman_url to foreman.domain by default Closed 10/08/2013
Related to Foreman - Feature #717: Add an option to overwrite foreman_url value for reverse ... Resolved 03/08/2011
Duplicated by Foreman - Bug #2559: in foreman_url() Port is still copied from users browser Closed 05/24/2013
Duplicated by Foreman - Bug #1461: preseed URL hardcoded to http (patch) Resolved 01/20/2012
Precedes Foreman - Bug #3659: "no implicit conversion of URI::HTTP into String" running... Closed 11/05/2013 11/05/2013

Associated revisions

Revision 8c618ae8
Added by Greg Sutcliffe over 4 years ago

Fixes #3569, #3210 - Use port from foreman_url for templates

Revision ce188941
Added by Dominic Cleal over 4 years ago

refs #3569 - fix URL validation test error on merge

History

#1 Updated by Dominic Cleal over 4 years ago

  • Status changed from Assigned to Ready For Testing

#2 Updated by Dominic Cleal over 4 years ago

  • Assigned To set to Greg Sutcliffe

#3 Updated by Greg Sutcliffe over 4 years ago

  • Duplicated by Bug #2559: in foreman_url() Port is still copied from users browser added

#4 Updated by Dominic Cleal over 4 years ago

  • Related to Bug #3210: We set foreman_url to foreman.domain by default added

#5 Updated by Dominic Cleal over 4 years ago

  • Release set to 1.4.0

#6 Updated by Greg Sutcliffe over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Dominic Cleal over 4 years ago

  • Duplicated by Bug #1461: preseed URL hardcoded to http (patch) added

#8 Updated by Dominic Cleal over 4 years ago

  • Related to Feature #717: Add an option to overwrite foreman_url value for reverse proxy use added

#9 Updated by Dominic Cleal over 4 years ago

  • Precedes Bug #3659: "no implicit conversion of URI::HTTP into String" running rake reports:summarize added

Also available in: Atom PDF