Project

General

Profile

Actions

Feature #3809

closed

Add rubocop to foreman

Added by David Davis almost 11 years ago. Updated about 6 years ago.


Description

Add rubocop to foreman as a lint checker for the Ruby code. A couple notes:

- To generate the config, use --auto-gen-config which will disable all failing rules and create a TODO list of things to address
- Use https://github.com/eitoball/rubocop-checkstyle_formatter to output XML for Jenkins

Check out our rubocop rake task in Katello for running rubocop via Jenkins:

https://github.com/Katello/katello/blob/628a01ad914e7c5d63c8d325e4798a8c19755cff/lib/katello/tasks/rubocop.rake


Related issues 6 (1 open5 closed)

Related to Katello - Bug #7022: Need to update rubocop to 0.24.1ClosedDavid Davis08/11/2014Actions
Related to Smart Proxy - Feature #7181: Add rubocop to smart-proxy codeClosed08/20/2014Actions
Related to Website - Feature #7179: Document how to run rubocopClosedDavid DavisActions
Related to Katello - Bug #7196: Tie into the Foreman rubocop rake taskRejectedActions
Related to Foreman - Bug #9231: Exception message missing when ENC fails to renderClosedDavid Davis02/05/2015Actions
Related to Foreman - Refactor #22058: Rubocop Tracker IssueNewActions
Actions #1

Updated by Dominic Cleal almost 11 years ago

  • Category set to Tests
Actions #2

Updated by David Davis over 10 years ago

  • Assignee set to David Davis
Actions #3

Updated by The Foreman Bot over 10 years ago

  • Status changed from New to Ready For Testing
  • Target version set to 1.7.5
  • Pull request https://github.com/theforeman/foreman/pull/1666 added
  • Pull request deleted ()
Actions #4

Updated by David Davis over 10 years ago

  • Related to Bug #7022: Need to update rubocop to 0.24.1 added
Actions #5

Updated by Anonymous over 10 years ago

  • Target version changed from 1.7.5 to 1.7.4
Actions #6

Updated by David Davis over 10 years ago

  • Related to Feature #7181: Add rubocop to smart-proxy code added
Actions #7

Updated by David Davis over 10 years ago

Actions #8

Updated by David Davis over 10 years ago

  • Related to Bug #7196: Tie into the Foreman rubocop rake task added
Actions #9

Updated by Dominic Cleal about 10 years ago

  • Translation missing: en.field_release set to 21
Actions #10

Updated by David Davis about 10 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #11

Updated by Dominic Cleal almost 10 years ago

  • Related to Bug #9231: Exception message missing when ENC fails to render added
Actions #12

Updated by The Foreman Bot over 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3521 added
Actions #13

Updated by The Foreman Bot over 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3625 added
Actions #14

Updated by The Foreman Bot over 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3634 added
Actions #15

Updated by The Foreman Bot over 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3643 added
Actions #16

Updated by The Foreman Bot about 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3834 added
Actions #17

Updated by Anonymous almost 7 years ago

Actions #18

Updated by The Foreman Bot about 6 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6029 added
Actions

Also available in: Atom PDF