Feature #4166

VMWare - VM editing is not implemented for this provider

Added by Markus Nussdorfer over 3 years ago. Updated 8 months ago.

Status:Closed
Priority:Normal
Assigned To:Timo Goebel
Category:Compute resources - VMware
Target version:-
Difficulty: Bugzilla link:1311243
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4146
Story points-
Velocity based estimate-
Release1.15.0Release relationshipAuto

Description

After upgrading to foreman-1.4.0-0.1.RC1

I am unable to edit the VM Settings
As it gives me EC2 as type i assume something else is broken

Applying the change from #3867 fixed the display issue, but not the real problem underneath

Here some more infos from the logs

yum update log

    Updated     foreman-1.3.2-1.el6.noarch                                          @foreman
    Update              1.4.0-0.1.RC1.el6.noarch                                    @foreman
    Updated     foreman-compute-1.3.2-1.el6.noarch                                  @foreman
    Update                      1.4.0-0.1.RC1.el6.noarch                            @foreman
    Updated     foreman-console-1.3.2-1.el6.noarch                                  @foreman
    Update                      1.4.0-0.1.RC1.el6.noarch                            @foreman
    Updated     foreman-postgresql-1.3.2-1.el6.noarch                               @foreman
    Update                         1.4.0-0.1.RC1.el6.noarch                         @foreman
    Updated     foreman-proxy-1.3.0-1.el6.noarch                                    @foreman
    Update                    1.4.0-0.1.RC1.el6.noarch                              @foreman
    Updated     foreman-selinux-1.3.0-1.el6.noarch                                  @foreman
    Update                      1.4.0-0.1.RC1.el6.noarch                            @foreman
    Updated     foreman-vmware-1.3.2-1.el6.noarch                                   @foreman
    Update                     1.4.0-0.1.RC1.el6.noarch                             @foreman
    Updated     ruby193-libyaml-0.1.4-5.el6.x86_64                                  @foreman
    Update                      0.1.4-5.el6.centos.alt.x86_64                       @scl
    Updated     ruby193-ruby-1.9.3.327-29.el6.x86_64                                @foreman
    Update                   1.9.3.448-40.1.el6.centos.alt.x86_64                   @scl
    Updated     ruby193-ruby-irb-1.9.3.327-29.el6.noarch                            @foreman
    Update                       1.9.3.448-40.1.el6.centos.alt.noarch               @scl
    Updated     ruby193-ruby-libs-1.9.3.327-29.el6.x86_64                           @foreman
    Update                        1.9.3.448-40.1.el6.centos.alt.x86_64              @scl
    Dep-Install ruby193-ruby-wrapper-0.0.2-4.el6.noarch                             @foreman
    Updated     ruby193-rubygem-bigdecimal-1.1.0-29.el6.x86_64                      @foreman
    Update                                 1.1.0-40.1.el6.centos.alt.x86_64         @scl
    Dep-Install ruby193-rubygem-bootstrap-sass-3.0.3.0-1.el6.noarch                 @foreman
    Updated     ruby193-rubygem-builder-3.0.0-3.el6.noarch                          @foreman
    Update                              3.0.0-3.el6.centos.alt.noarch               @scl
    Updated     ruby193-rubygem-excon-0.25.3-2.el6.noarch                           @foreman
    Update                            0.31.0-1.el6.noarch                           @foreman
    Updated     ruby193-rubygem-fast_gettext-0.8.0-2.el6.noarch                     @foreman
    Update                                   0.8.0-5.el6.noarch                     @foreman
    Updated     ruby193-rubygem-fog-1.15.0-2.el6.noarch                             @foreman
    Update                          1.19.0-1.el6.noarch                             @foreman
    Updated     ruby193-rubygem-io-console-0.3-29.el6.x86_64                        @foreman
    Update                                 0.3-40.1.el6.centos.alt.x86_64           @scl
    Updated     ruby193-rubygem-journey-1.0.4-2.el6.noarch                          @foreman
    Update                              1.0.4-2.el6.centos.alt.noarch               @scl
    Updated     ruby193-rubygem-json-1.5.4-29.el6.x86_64                            @foreman
    Update                           1.5.5-40.1.el6.centos.alt.x86_64               @scl
    Updated     ruby193-rubygem-multi_json-1.3.6-11.el6.noarch                      @foreman
    Update                                 1.8.2-1.el6.noarch                       @foreman
    Updated     ruby193-rubygem-passenger-4.0.5-5.el6.x86_64                        @foreman
    Update                                4.0.5-7.el6.x86_64                        @foreman
    Updated     ruby193-rubygem-passenger-native-4.0.5-5.el6.x86_64                 @foreman
    Update                                       4.0.5-7.el6.x86_64                 @foreman
    Updated     ruby193-rubygem-passenger-native-libs-4.0.5-5.el6.x86_64            @foreman
    Update                                            4.0.5-7.el6.x86_64            @foreman
    Updated     ruby193-rubygem-rack-1:1.4.1-5.el6.noarch                           @foreman
    Update                           1:1.4.1-5.el6.centos.alt.noarch                @scl
    Updated     ruby193-rubygem-rack-test-0.6.1-3.el6.noarch                        @foreman
    Update                                0.6.1-3.el6.centos.alt.noarch             @scl
    Updated     ruby193-rubygem-rails-1:3.2.8-2.el6.noarch                          @foreman
    Update                            1:3.2.8-2.el6.centos.alt.noarch               @scl
    Dep-Install ruby193-rubygem-rails3_before_render-0.2.0-1.el6.noarch             @foreman
    Updated     ruby193-rubygem-railties-3.2.8-3.el6.noarch                         @foreman
    Update                               3.2.8-3.el6.centos.alt.noarch              @scl
    Updated     ruby193-rubygem-rake-0.9.2.2-29.el6.noarch                          @foreman
    Update                           0.9.2.2-40.1.el6.centos.alt.noarch             @scl
    Updated     ruby193-rubygem-sass-3.1.20-3.el6.noarch                            @foreman
    Update                           3.2.13-1.el6.noarch                            @foreman
    Updated     ruby193-rubygem-therubyracer-0.11.0-0.4.beta5.el6.x86_64            @foreman
    Update                                   0.11.0-0.6.beta5.el6.centos.alt.x86_64 @scl
    Updated     ruby193-rubygem-tilt-1.3.3-9.el6.noarch                             @foreman
    Update                           1.3.3-10.el6.centos.alt.noarch                 @scl
    Updated     ruby193-rubygem-treetop-1.4.10-6.el6.noarch                         @foreman
    Update                              1.4.10-6.el6.centos.alt.noarch              @scl
    Dep-Install ruby193-rubygem-unf-0.1.3-3.el6.x86_64                              @foreman
    Dep-Install ruby193-rubygem-unf_ext-0.0.6-4.el6.x86_64                          @foreman
    Updated     ruby193-runtime-1-9.el6.x86_64                                      @foreman
    Update                      1-11.el6.centos.alt.x86_64                          @scl
    Updated     ruby193-v8-1:3.10.8-7.el6.x86_64                                    @foreman
    Update                 1:3.14.5.10-2.el6.centos.alt.x86_64                      @scl
    Updated     rubygem-passenger-4.0.5-5.el6.x86_64                                @foreman
    Update                        4.0.5-7.el6.x86_64                                @foreman
    Updated     rubygem-passenger-native-4.0.5-5.el6.x86_64                         @foreman
    Update                               4.0.5-7.el6.x86_64                         @foreman
    Updated     rubygem-passenger-native-libs-4.0.5-5.el6.x86_64                    @foreman
    Update                                    4.0.5-7.el6.x86_64                    @foreman
    Updated     rubygem-rubyipmi-0.6.0-2.el6.noarch                                 @foreman
    Update                       0.7.0-1.el6.noarch                                 @foreman
    Updated     scl-utils-20120927-8.el6.x86_64                                     @anaconda-CentOS-201311272149.x86_64/6.5
    Update                20120927-8.el6.centos.alt.x86_64                          @scl

cat db_migrate.log
NOTICE:  CREATE TABLE will create implicit sequence "compute_profiles_id_seq" for serial column "compute_profiles.id" 
NOTICE:  CREATE TABLE / PRIMARY KEY will create implicit index "compute_profiles_pkey" for table "compute_profiles" 
NOTICE:  CREATE TABLE will create implicit sequence "compute_attributes_id_seq" for serial column "compute_attributes.id" 
NOTICE:  CREATE TABLE / PRIMARY KEY will create implicit index "compute_attributes_pkey" for table "compute_attributes" 
==  RemoveUnusedRoleFields: migrating =========================================
-- remove_column(:users, :role_id)
   -> 0.7518s
-- remove_column(:user_roles, :inherited_from)
   -> 0.0044s
==  RemoveUnusedRoleFields: migrated (0.7564s) ================================

==  AddComposeFlagAndShortNameToFactName: migrating ===========================
-- add_column(:fact_names, :compose, :boolean, {:default=>false, :null=>false})
   -> 0.2143s
-- add_column(:fact_names, :short_name, :string)
   -> 0.0186s
==  AddComposeFlagAndShortNameToFactName: migrated (0.2331s) ==================

==  AllowNullValuesOnFactValue: migrating =====================================
-- change_column(:fact_values, :value, :text, {:null=>true})
   -> 0.0178s
==  AllowNullValuesOnFactValue: migrated (0.0179s) ============================

==  AddTypeToFactName: migrating ==============================================
-- add_column(:fact_names, :type, :string, {:default=>"FactName"})
   -> 0.0128s
==  AddTypeToFactName: migrated (0.0129s) =====================================

==  ChangeNameIndexOnFactName: migrating ======================================
-- remove_index(:fact_names, {:column=>:name, :unique=>true})
   -> 0.0422s
-- add_index(:fact_names, [:name, :type], {:unique=>true})
   -> 0.0972s
==  ChangeNameIndexOnFactName: migrated (0.1396s) =============================

==  UpdateForemanUrl: migrating ===============================================
==  UpdateForemanUrl: migrated (0.5138s) ======================================

==  AddAncestryToFactNames: migrating =========================================
-- add_column(:fact_names, :ancestry, :string)
   -> 0.0009s
-- add_index(:fact_names, :ancestry)
   -> 0.0063s
==  AddAncestryToFactNames: migrated (0.0073s) ================================

==  AddPxegrubLocalbootTemplate: migrating ====================================
==  AddPxegrubLocalbootTemplate: migrated (0.0000s) ===========================

==  RenameSeededTemplates: migrating ==========================================
==  RenameSeededTemplates: migrated (0.6029s) =================================

==  AddDescriptionToOperatingsystem: migrating ================================
-- add_column(:operatingsystems, :description, :string)
   -> 0.0167s
==  AddDescriptionToOperatingsystem: migrated (0.0167s) =======================

==  AddUserdataFlagToImages: migrating ========================================
-- add_column(:images, :user_data, :boolean, {:default=>false})
   -> 0.0088s
==  AddUserdataFlagToImages: migrated (0.0088s) ===============================

==  CreateComputeProfiles: migrating ==========================================
-- create_table(:compute_profiles)
   -> 0.0353s
==  CreateComputeProfiles: migrated (0.0354s) =================================

==  CreateComputeAttributes: migrating ========================================
-- create_table(:compute_attributes)
   -> 0.0400s
-- add_index(:compute_attributes, :compute_profile_id)
   -> 0.0044s
-- add_index(:compute_attributes, :compute_resource_id)
   -> 0.0043s
-- add_foreign_key("compute_attributes", "compute_resources", {:name=>"compute_attributes_compute_resource_id_fk"})
   -> 0.0717s
-- add_foreign_key("compute_attributes", "compute_profiles", {:name=>"compute_attributes_compute_profile_id_fk"})
   -> 0.0014s
==  CreateComputeAttributes: migrated (0.1222s) ===============================

==  AddComputeProfileToHostgroup: migrating ===================================
-- add_column(:hostgroups, :compute_profile_id, :integer)
   -> 0.0009s
-- add_column(:hosts, :compute_profile_id, :integer)
   -> 0.0229s
-- add_index(:hostgroups, :compute_profile_id)
   -> 0.0122s
-- add_index(:hosts, :compute_profile_id)
   -> 0.0095s
-- add_foreign_key("hostgroups", "compute_profiles", {:name=>"hostgroups_compute_profile_id_fk"})
   -> 0.0015s
-- add_foreign_key("hosts", "compute_profiles", {:name=>"hosts_compute_profile_id_fk"})
   -> 0.0030s
==  AddComputeProfileToHostgroup: migrated (0.0503s) ==========================

Related issues

Related to Foreman - Bug #11656: Network interface dropdowns not disabled on VMware host e... Closed 09/02/2015

Associated revisions

Revision d5f47458
Added by Timo Goebel 8 months ago

fixes #4166 - vmware: update cpus, memory for vms

Revision 8724af05
Added by Dominic Cleal 8 months ago

refs #4166 - use fog-vsphere 1.6.0+

History

#1 Updated by Dominic Cleal over 3 years ago

  • Status changed from New to Need more information
  • Release deleted (1.4.0)

The message about VM editing is simply to say that Foreman can't change the details of existing VMs at the moment - you'll need to use vSphere itself for that. 1.3 might have given the impression that you could, but on update it wouldn't have changed anything, so we added these notices to let users know.

I'm not sure I understand the point about EC2, could you elaborate on how to reproduce this issue please?

#2 Updated by Markus Nussdorfer over 3 years ago

thanks for clarification.
on host creation it works as expected, therefore everything is good.

about the EC2-Type, it seems that in fact it is a duplicate of #3867
to reproduce:

create new compute resource -> choose vmware as provider -> safe
in the overview the type is displayed as EC2

due to the greyed out fields i had the impression it was a different issue.

#3 Updated by Dominic Cleal over 3 years ago

  • Tracker changed from Bug to Feature
  • Status changed from Need more information to New
  • Priority changed from High to Normal

Thanks for the confirmation, the fix for #3867 will go out today in RC2. I'll leave this open, but as a feature request for VM editing under VMware.

#4 Updated by Markus Nussdorfer over 3 years ago

sounds great to me
thanks for the quick response and keep up the excellent work

#5 Updated by Dominic Cleal almost 3 years ago

  • Category changed from Compute resources to Compute resources - VMware

#6 Updated by David Somers-Harris over 2 years ago

Does this mean that I can't add disks to an existing VMWare instance with Foreman yet?

#7 Updated by Dominic Cleal over 2 years ago

David Somers-Harris wrote:

Does this mean that I can't add disks to an existing VMWare instance with Foreman yet?

Correct.

#8 Updated by Dominic Cleal almost 2 years ago

  • Related to Bug #11656: Network interface dropdowns not disabled on VMware host edits added

#9 Updated by Bryan Kearney over 1 year ago

  • Bugzilla link set to 1311243

#10 Updated by Timo Goebel 8 months ago

  • Status changed from New to Assigned
  • Assigned To set to Timo Goebel

It's quite easy to implement this for cpus, corespersocket and memory for starters.
I've filed a PR against fog-vsphere to implement the necessary changes.
https://github.com/fog/fog-vsphere/pull/63

Changes to foreman:
https://github.com/timogoebel/foreman/tree/4166-vmware-vm-editing

#11 Updated by The Foreman Bot 8 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4146 added

#12 Updated by Timo Goebel 8 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#13 Updated by Dominic Cleal 8 months ago

  • Release set to 1.15.0

Also available in: Atom PDF