Bug #5209
closed
Negative timeout config value causes errors
Description
Our example config file advises to use -1 for infinite timeouts.
https://github.com/theforeman/hammer-cli-foreman/blob/master/config/foreman.yml#L10
This can cause "time interval must be positive (ArgumentError)" exception on some ruby versions.
According to the docs the solution seems to be using 0 instead of -1.
http://ruby-doc.org/stdlib-1.9.3/libdoc/timeout/rdoc/Timeout.html#method-c-timeout
We should change our sample config and check values < 0 before the timeout is set.
Updated by Tomáš Strachota over 10 years ago
- Status changed from New to Ready For Testing
- Assignee set to Tomáš Strachota
- Target version set to 1.8.4
Updated by Anonymous over 10 years ago
- Target version changed from 1.8.4 to 1.8.3
Updated by Anonymous over 10 years ago
- Target version changed from 1.8.3 to 1.8.4
Updated by Anonymous over 10 years ago
- Target version changed from 1.8.4 to 1.8.3
Updated by Anonymous over 10 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset hammer-cli-foreman|commit:337cba41bbb5c6472bf1c557367deff48d2da589.
Updated by Tomáš Strachota over 10 years ago
- Status changed from Closed to Ready For Testing
Re-opening as I found some issues with different versions of rest-client:
https://github.com/theforeman/hammer-cli-foreman/pull/114
Updated by Anonymous over 10 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset hammer-cli-foreman|commit:e89ff88932a1ff37bf436b36175fbaa35ea7f2d0.